Use gnulib #311
Open
Use gnulib #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INET_ADDRSTRLEN is portable and allow to be robust against special crafted adress signed-off: Bastien Roucariès <rouca@debian.org>
getaddrinfo is the correct API for resolving IP and checking correctness Use it, instead of manual parsing
Less code and less copy/paste thus less errors
Signed-off-by: Bastien Roucariès <rouca@debian.org>
Avoid circular depends by moving dump function to fko lib. Use libtool
gnulib allow to simplify code by using stdint module Signed-off-by: Bastien Roucariès <rouca@debian.org>
Signed-off-by: Bastien Roucariès <rouca@debian.org>
Signed-off-by: Bastien Roucariès <rouca@debian.org>
Signed-off-by: Bastien Roucariès <rouca@debian.org>
Thanks to gnulib use it inconditionally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Above the siplify address a patchset that allow to use gnulib.
I plan to push more change simplifying fwknop by using well know and tested function from gnulib
It will allow to simplify the code
bastien