Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check with multiple mruby versions #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

takumin
Copy link

@takumin takumin commented Oct 28, 2023

- Support multiple mruby versions
  - `2.0.1`
  - `2.1.2`
  - `3.0.0`
  - `3.1.0`
  - `3.2.0`
- Workaround for mruby 2.0.1 build failure on Ruby 3.0 or higher
  - Ruby 3.0 a method delegating all arguments must explicitly delegate
    keyword arguments in addition to positional arguments.
  - Where to apply monkey patch:
    https://github.com/mruby/mruby/blob/2.0.1/Rakefile#L37-L39
  - See also:
    https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
- Update `actions/checkout@v1.0.0` to `actions/checkout@v4`
  - Remove fetch-depth option
  - Add submodules option
- Change `${MRUBY_BUILD}` to `${MRUBY_CONFIG}`
  - Display mruby-yaml in mruby build summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant