Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Update qunit to solve Windows failure. #23505

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Test: Update qunit to solve Windows failure. #23505

merged 2 commits into from
Feb 16, 2022

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 16, 2022

Fixed #23424.

Description

The latest qunit release fixed the Windows import issue with ESM modules (see qunitjs/qunit#1675).

@mrdoob mrdoob added this to the r138 milestone Feb 16, 2022
@mrdoob mrdoob merged commit c7d2bb2 into mrdoob:dev Feb 16, 2022
@mrdoob
Copy link
Owner

mrdoob commented Feb 16, 2022

Thanks!

donmccurdy pushed a commit to donmccurdy/three.js that referenced this pull request Mar 10, 2022
* Test: Update qunit to solve Windows failure.

* Update package-lock.json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests on Node.js don't run locally (on Windows?)
2 participants