Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Revert usage of setAnimationLoop(). #28322

Closed
wants to merge 5 commits into from
Closed

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented May 9, 2024

Related issue: #28296

Description

As suggested #28296 (comment) this PR reverts the usage of setAnimationLoop() in the examples to restore E2E testing.

@Mugen87 Mugen87 mentioned this pull request May 9, 2024
@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 9, 2024

Um, the E2E tests still fail (sometimes with very large diffs) 🤔 .

The only thing that is now different compared to last month is ci.yml which contains the migration task for the higher actions/upload-artifact version, see actions/upload-artifact#506.

Our change: 37e1cb5

@gkjohnson
Copy link
Collaborator

gkjohnson commented May 9, 2024

Could it be worth pinging some of the people who work on the extensions at @actions to see if there's anything more obvious to them that might have changed?

Thanks for putting so much effort into fixing this, by the way 🙏

@Mugen87 Mugen87 marked this pull request as draft May 9, 2024 09:13
@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 9, 2024

I have reverted the changes to ci.yml so we use actions/upload-artifact@v3 but still no luck. I also see many of those in the console:

JSHandle:THREE.WebGLRenderer: Error creating WebGL context., another attempt...

It seems there is a more fundamental issue with the workflow runner environment.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented May 9, 2024

Closing. The root cause was not actions/upload-artifact and not setAnimationLoop() but macos-latest as the environment.

@Mugen87 Mugen87 closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants