Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fixed TODO: Bind lexical this #28357

Merged
merged 1 commit into from May 13, 2024

Conversation

ycw
Copy link
Contributor

@ycw ycw commented May 13, 2024

This PR fixed a TODO in ui.three.js about binding this without .bind(); this.update is consumed here:

UIPoints2

const txtX = new UINumber( x ).setWidth( '30px' ).onChange( this.update );
const txtY = new UINumber( y ).setWidth( '30px' ).onChange( this.update );

UIPoints3

const txtX = new UINumber( x ).setWidth( '30px' ).onChange( this.update );
const txtY = new UINumber( y ).setWidth( '30px' ).onChange( this.update );
const txtZ = new UINumber( z ).setWidth( '30px' ).onChange( this.update );

@Mugen87 Mugen87 added this to the r165 milestone May 13, 2024
@Mugen87 Mugen87 merged commit 86a4d25 into mrdoob:dev May 13, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants