Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customRender return sourceMap support #249

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Conversation

qyzzzz
Copy link
Contributor

@qyzzzz qyzzzz commented Jan 11, 2024

When using customRender, support for returning sourceMap is added.
This PR addresses the issue where goToDefinition functionality was not working when using customRender because customRender was unable to provide sourceMap.

@qyzzzz qyzzzz marked this pull request as ready for review January 11, 2024 12:58
@mrmckeb
Copy link
Owner

mrmckeb commented Feb 11, 2024

HI @qyzzzz, sorry for the delay here. I wanted to make changes on your branch, but couldn't push to it - so I'll make the change after I merge.

The only real change here is that map will become sourceMap.

@mrmckeb mrmckeb merged commit 86d2c78 into mrmckeb:main Feb 11, 2024
1 check passed
@mrmckeb
Copy link
Owner

mrmckeb commented Feb 11, 2024

This has now shipped in v5.1.0. Thanks again!

davydkov pushed a commit to likec4/likec4 that referenced this pull request Feb 24, 2024
#586)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[typescript-plugin-css-modules](https://togithub.com/mrmckeb/typescript-plugin-css-modules)
| [`^5.0.2` ->
`^5.1.0`](https://renovatebot.com/diffs/npm/typescript-plugin-css-modules/5.0.2/5.1.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/typescript-plugin-css-modules/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/typescript-plugin-css-modules/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/typescript-plugin-css-modules/5.0.2/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/typescript-plugin-css-modules/5.0.2/5.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>mrmckeb/typescript-plugin-css-modules
(typescript-plugin-css-modules)</summary>

###
[`v5.1.0`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v5.1.0)

[Compare
Source](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v5.0.2...v5.1.0)

#### What's Changed

- chore: update dependencies by
[@&#8203;mrmckeb](https://togithub.com/mrmckeb) in
[mrmckeb/typescript-plugin-css-modules#255
- feat: add env var to disable plugin by
[@&#8203;ekilah](https://togithub.com/ekilah) in
[mrmckeb/typescript-plugin-css-modules#244
- docs: update README regexp by
[@&#8203;mrmckeb](https://togithub.com/mrmckeb) in
[mrmckeb/typescript-plugin-css-modules#256
- feat(getCssExports): adds support for SCSS/SASS partials via aliases
by [@&#8203;rmachado-studocu](https://togithub.com/rmachado-studocu) in
[mrmckeb/typescript-plugin-css-modules#251
- feat: customRender return sourceMap support by
[@&#8203;qyzzzz](https://togithub.com/qyzzzz) in
[mrmckeb/typescript-plugin-css-modules#249

#### New Contributors

- [@&#8203;rmachado-studocu](https://togithub.com/rmachado-studocu) made
their first contribution in
[mrmckeb/typescript-plugin-css-modules#251
- [@&#8203;qyzzzz](https://togithub.com/qyzzzz) made their first
contribution in
[mrmckeb/typescript-plugin-css-modules#249

**Full Changelog**:
mrmckeb/typescript-plugin-css-modules@v5.0.2...v5.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/likec4/likec4).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants