Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-259: Convert smoke tests to e2e tests #387

Merged
merged 1 commit into from
Apr 18, 2023
Merged

ISSUE-259: Convert smoke tests to e2e tests #387

merged 1 commit into from
Apr 18, 2023

Conversation

mrmlnc
Copy link
Owner

@mrmlnc mrmlnc commented Apr 18, 2023

What is the purpose of this pull request?

Replace the node-glob comparison tests by e2e tests with snapshots to validate changes within this package against our suites.

What changes did you make? (Give an overview)

  1. This pull request captures in snapshots the current behavior of the package.
  2. This package use the mocha test runner which does not support snapshots. I don't want to use other runners due to various reasons. That's why we use the snap-shot-it package. This package is not very good (slow, mostly), but other options do not suit me.

@mrmlnc mrmlnc force-pushed the snapshots branch 12 times, most recently from b9901ad to bd5c577 Compare April 18, 2023 17:49
@mrmlnc mrmlnc force-pushed the snapshots branch 7 times, most recently from ac0d00c to ac45594 Compare April 18, 2023 19:00
@mrmlnc mrmlnc marked this pull request as ready for review April 18, 2023 19:19
@mrmlnc mrmlnc merged commit 6f9f9a6 into master Apr 18, 2023
30 checks passed
@mrmlnc mrmlnc deleted the snapshots branch April 28, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant