Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multy node with redisson receive multy same message #552

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

multy node with redisson receive multy same message #552

wants to merge 8 commits into from

Conversation

541595308
Copy link

bug:
when socketio run with multy node use redisson, broadcast will send all rooms in namespace at other node when i only broadcast to a room

solution:
Specify a namespace and room for broadcast

541595308 and others added 3 commits May 4, 2018 22:11
@541595308
Update README.md
b6d134b
bug:
37ab8ab 
when socketio run with multy node use redisson, broadcast will send all rooms in namespace at other node when i only broadcast to a room
solution:
Specify a namespace and room for broadcast
Merge remote-tracking branch 'upstream/master'
d7a6a09 
fork of mrniko/netty-socketio
@541595308
Copy link
Author

solve pom.xml conflict

@mrniko mrniko added this to the 1.7.17 milestone Nov 25, 2018
541595308 and others added 2 commits July 31, 2019 17:44
@541595308
Merge pull request #1 from mrniko/master
0fe0d2b 
merge v 1.7.17
Merge branch 'source'
8e2e7a9 
# Conflicts:
#	pom.xml
#	src/main/java/com/corundumstudio/socketio/store/RedissonPubSubStore.java
@slimmaddy
Copy link

is this verified? i really need multiple and single broadcast in this branch. thank you

@mrniko mrniko modified the milestones: 1.7.17, 1.7.18 Sep 4, 2019
@541595308
Copy link
Author

Yes, I have been running online for a long time. On the line, I run 4 nodes and communicated with each other through redisson broadcast.

@mrniko mrniko modified the milestones: 1.7.18, 1.7.19 Aug 4, 2020
@GaryLeung922
Copy link

I want to know when the feature can be added.

mrniko
mrniko reviewed Aug 8, 2020
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
mrniko
mrniko reviewed Aug 8, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
mrniko
mrniko requested changes Aug 8, 2020
View reviewed changes
Copy link
Owner

@mrniko mrniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make changes

@mrniko
Copy link
Owner

mrniko commented Aug 8, 2020 •
edited

@desperatel @541595308

Some changes need before I can merge it

@GaryLeung922
Copy link

@mrniko thanks~
I can't wait to use this bugfix for my project.
Should I fix it by myself in my project this time and then wait for this bugfix in 1.7.19?

@GaryLeung922 GaryLeung922 mentioned this pull request Aug 11, 2020
Merged
@541595308
Copy link
Author

@mrniko I have changed.

@GaryLeung922
Copy link

@541595308 Could I have your email or other contacts?

@SebastienMelki
Copy link

Hello @mrniko , I was wondering why this isn't merged yet? I have an issue where every time i send an event to a room, there are two events that are published on redis, which makes my other servers broadcast the same message twice to a room :/

@mrniko mrniko modified the milestones: 1.7.19, 1.7.23 Oct 12, 2022
@mrniko mrniko modified the milestones: 1.7.23, 1.7.24 Apr 14, 2023
@mrniko mrniko modified the milestones: 1.7.24, 2.0.1 May 14, 2023
@mrniko mrniko modified the milestones: 2.0.1, 2.0.3 Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryLeung922 GaryLeung922 GaryLeung922 left review comments

@mrniko mrniko mrniko requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@541595308 @slimmaddy @GaryLeung922 @mrniko @SebastienMelki