fix the issue of not reading too long file. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
although a bit offtopic, but i recommend |
mrombout
requested changes
May 6, 2024
| return poFile, err | ||
| f, e := os.Open(filePath) | ||
| if e != nil { | ||
| panic(e) |
There was a problem hiding this comment.
I think it's better to keep the panic()s in the main and use plain errors throughout the code base.
Suggested change
| panic(e) | |
| return poFile, err |
| content, err := fs.readFile(filePath) | ||
| if err != nil { | ||
| return poFile, err | ||
| f, e := os.Open(filePath) |
There was a problem hiding this comment.
Revert to err to keep in line with standard go practices.
Suggested change
| f, e := os.Open(filePath) | |
| f, err := os.Open(filePath) |
| content, err := fs.readFile(filePath) | ||
| if err != nil { | ||
| return poFile, err | ||
| f, e := os.Open(filePath) |
There was a problem hiding this comment.
In order to keep the tests working, this os.Open call needs to go through the fileSystem interface and then be mocked.
Or better yet, these days it's probably better to rely on fs.FS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
longer than 65565 bytes content will not be processed.