Support multivalue in component config #825
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* FEAT: Allow multivalue for Config attibutes * Documentation for multivalue behaviour
Added Component.getConfigFirstOrDefault to behave like the old getConfig implementation returning first item or empty string
|
I tested it locally and everything seems to work as expected/described. No Idea why the test for Keycloak 19 failes. The error seems to be completely unrelated. On my first commit it was version 18 that failed a bit strange... |
ChrisHubinger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
Componentto allow the usage of multivalued configuration settings.Changed:
func (component *component) getConfig(val string) string=>func (component *component) getConfig(val string) []stringCreated new:
func (component *component) getConfigFirstOrDefault(val string) stringas replacement for original
getConfigfixed all usage thoughout the code.Implementation Note:
Keycloak API does not preserver order for config values on it's own. Therefore the config value arrays are sorted using code, preventing creation of no-op changesets due to ordering changes between runs.
Just a gues, but look exactly like those issues about attributes/values order:
keycloak/keycloak#9712
keycloak/keycloak#9794