Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 919 provider crash #922

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

TBeijen
Copy link

@TBeijen TBeijen commented Jan 19, 2024

Fix for #919

Always refresh token after create realm.

Rationale is this should not be expensive since:

  • Creating a realm is relatively rare
  • In a lot of scenarios the token refresh would happen anyway if a new realm is created, when it's referenced elsewhere

Existing acceptance test testKeycloakDefaultRoles_basic should cover this, provided the acceptance tests include Keycloak v22 and newer. For that, the following PRs exist:

Copy link

@vincent-petit vincent-petit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants