Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for the ExcludeIssuerFromAuthResponse option on OpenIdClient #934

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sebght
Copy link

@sebght sebght commented Feb 28, 2024

Solves #928

What has been changed :

  • new ExcludeIssuerFromAuthResponse attribute in the client
  • the resource schema is updated with ExcludeIssuerFromAuthResponse attribute
  • the datasource openid_client also returns this attribute
  • tests were updated + one new test case to check that the option is well updated
  • provider documentation returns the new attribute with the same words Keycloak uses

@paul-pch
Copy link

paul-pch commented Mar 4, 2024

I've been struggling with this exat configuration. Thanks for the PR !

@sebght
Copy link
Author

sebght commented Mar 5, 2024

My tests have led me to think that the option is changed to false until it's not explicitly given to the API... This means everytime you terraform apply your client resource, it will set it back to false...
Kind of a thorn in the side for ppl I guess (for me it is 😅). Should we consider a v4.4.1 @mrparkers ?

@sebght
Copy link
Author

sebght commented Mar 5, 2024

Nevermind, I did more precise tests and they prove that the option is not overwritten every apply. Sorry for the spamming !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants