Don't transform homepage URL

mskelton · Dec 23, 2022 · 136a1e1 · 136a1e1
1 parent a22a2ca
commit 136a1e1
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 8 deletions.
diff --git a/bundles/@yarnpkg/plugin-outdated.js b/bundles/@yarnpkg/plugin-outdated.js
diff --git a/src/utils.ts b/src/utils.ts
@@ -7,14 +7,18 @@ export const truthy = Boolean as unknown as <T>(
 ) => arg is T
 
 export function getHomepageURL({ raw: manifest }: Manifest): string | null {
+  // Prefer the homepage over the repository URL
+  if (manifest.homepage) {
+    return manifest.homepage
+  }
+
   const repo = manifest.repository
-  const repoURL = manifest.homepage
-    ? manifest.homepage
-    : typeof repo === "string"
-    ? repo
-    : typeof repo === "object" && typeof repo.url === "string"
-    ? repo.url
-    : null
+  const repoURL =
+    typeof repo === "string"
+      ? repo
+      : typeof repo === "object" && typeof repo.url === "string"
+      ? repo.url
+      : null
 
   const info = repoURL ? fromUrl(repoURL) : undefined
   const commitish = info?.committish ? `#${info.committish}` : ""

diff --git a/test/specs/url.spec.ts b/test/specs/url.spec.ts
@@ -72,6 +72,12 @@ test.describe("yarn outdated --url", () => {
     expect(
       getURL({ homepage: "http://foo.com", repository: "http://bar.com" })
     ).toBe("http://foo.com")
+    expect(
+      getURL({
+        homepage: "https://github.com/foo/bar/tree/master/packages/a#readme",
+        repository: "https://github.com/bar/foo",
+      })
+    ).toBe("https://github.com/foo/bar/tree/master/packages/a#readme")
   })
 
   test.describe("when outdatedIncludeURL config is true", () => {