fix: upgrade to strict-event-emitter@0.4.3 #382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
force-pushed
the
backport/0.17.20-strict-event-emitter
branch
from
fb73793
to
a88ad86
Compare
kettanaito
commented
Jun 13, 2023
| export type FunctionEventMapToStrictEventEmitterMap< | ||
| Functions extends FunctionEventMap | ||
| > = { | ||
| [K in keyof Functions]: Parameters<Functions[K]> |
There was a problem hiding this comment.
EventMapType and EventMap types are different across strict-event-emitter 0.2 and 0.5. Adding this transformer type to account for that difference since the events contract in Interceptors uses Record<string, Function> index signature to allow specifying the expected return type of the events (since those can be awaited, etc).
kettanaito
force-pushed
the
backport/0.17.20-strict-event-emitter
branch
from
a88ad86
to
a2006ba
Compare
kettanaito
changed the title
4 tasks
4 tasks
|
This branch is extremely old. Closing this. If this is still relevant, we should open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class extends value undefined is not a constructor or nulloccurs after the version upgrade from 0.49.2 to the latest version msw#1539Upgrading
strict-event-emitterto the same version range as in the latest MSW (1.x). Since MSW 2.x, thestrict-event-emmiteris on 0.5.