-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Tweaks on getting started page #329
base: master
Are you sure you want to change the base?
Conversation
Base UI is a library of unstyled React UI components and hooks. | ||
These components were extracted from [Material UI](https://mui.com/material-ui/), and are now available as a standalone package. | ||
They feature the same robust engineering but without implementing Material Design. | ||
Our goal with Base UI is to provide a complete set of accessible UI components but with maximum flexibility. We want to facilitate creative user interfaces and help teams ship high-quality products. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.We] Try to avoid using first-person plural like 'Our'.
Base UI is a library of unstyled React UI components and hooks. | ||
These components were extracted from [Material UI](https://mui.com/material-ui/), and are now available as a standalone package. | ||
They feature the same robust engineering but without implementing Material Design. | ||
Our goal with Base UI is to provide a complete set of accessible UI components but with maximum flexibility. We want to facilitate creative user interfaces and help teams ship high-quality products. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.We] Try to avoid using first-person plural like 'We'.
|
||
Base UI includes prebuilt components with production-ready functionality, along with low-level hooks for transferring that functionality to other components. | ||
Base UI components are React-based, are built by the same team that created [Material UI](https://mui.com/material-ui/), and feature the same robust engineering but without any styling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[MUI.MuiBrandName] Use a non-breaking space (option+space on Mac, Alt+0160 on Windows or AltGr+Space on Linux, instead of space) for brand name ('Base UI' instead of 'Base UI')
|
||
With Base UI, you can rapidly build on top of our foundational components using any styling solution you choose—no need to override any default style engine or theme. | ||
With Base UI, you can rapidly build on top of our foundational components using any styling or animation solution you choose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.We] Try to avoid using first-person plural like 'our'.
Base UI features many of the same components as [Material UI](https://mui.com/material-ui/getting-started/), but without the Material Design implementation. | ||
|
||
Base UI is not packaged with any default theme or built-in style engine. | ||
Unlike Material UI, Base UI does not include any default theme or built-in style engine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[MUI.MuiBrandName] Use a non-breaking space (option+space on Mac, Alt+0160 on Windows or AltGr+Space on Linux, instead of space) for brand name ('Material UI' instead of 'Material UI')
This makes it a great choice if you need complete control over how your app's CSS is implemented. | ||
|
||
You could think of Base UI as the "skeletal" or "headless" version of Material UI—in fact, future versions of Material UI will gradually adopt these components and hooks for their foundational structure. | ||
Future versions of Material UI will gradually adopt Base UI as its foundation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.Will] Avoid using 'will'.
This makes it a great choice if you need complete control over how your app's CSS is implemented. | ||
|
||
You could think of Base UI as the "skeletal" or "headless" version of Material UI—in fact, future versions of Material UI will gradually adopt these components and hooks for their foundational structure. | ||
Future versions of Material UI will gradually adopt Base UI as its foundation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[MUI.MuiBrandName] Use a non-breaking space (option+space on Mac, Alt+0160 on Windows or AltGr+Space on Linux, instead of space) for brand name ('Base UI' instead of 'Base UI')
|
||
## Style your component | ||
|
||
Base UI makes no assumptions about style at all. You're free to style your components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [vale] reported by reviewdog 🐶
[MUI.MuiBrandName] Use a non-breaking space (option+space on Mac, Alt+0160 on Windows or AltGr+Space on Linux, instead of space) for brand name ('Base UI' instead of 'Base UI')
This makes it a great choice if you need complete control over how your app's CSS is implemented. | ||
|
||
You could think of Base UI as the "skeletal" or "headless" version of Material UI—in fact, future versions of Material UI will gradually adopt these components and hooks for their foundational structure. | ||
Future versions of Material UI will gradually adopt Base UI as its foundation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Google.Will] Avoid using 'will'.
@@ -52,12 +52,6 @@ You can search through existing questions and answers to see if someone has aske | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the support page conent, I think that all open-source projects should have the same structure, unless there is a strong reason not to:
- Tidelift: I don't see a reason for this to be different, so either to delete it everywhere or keep it everywhere. Since Tidelift pays us, it would make sense to me to have it, but maybe to reshape.
- Custom work: same incentive as 1. The soft objective was to offer people the open to shuffle the roadmap if some folks are willing to spend enough for it, but the main idea was for organizations to feel like they could spend $ to get unstuck, vs. staying stuck. I don't see strong arguments either way (remove it everywhere or add it everywhere).
- Social media. Ok, I guess maybe only MUI X would make sense to post on LinkedIn? cc @joserodolfofreitas. We would then update all the other products cc @samuelsycamore
- Technical support. same incentive as 1. The problem is that MUI X paid clients ask about paid support on Base UI which isn't included in their plan today, we needed this to make it clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted 1, 2, 4.
On 3, I don't think there's a benefit to posting on LinkedIn about Base UI, or a benefit to linking to it. So I left that out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a quick look
# Base UI - Overview | ||
# Overview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
```jsx | ||
import * as React from 'react'; | ||
import * as NumberField from '@base_ui/react/NumberField'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used
import * as NumberField from '@base_ui/react/NumberField'; | |
import * as BaseNumberField from '@base_ui/react/NumberField'; |
in the demos of the docs, maybe it's not relevant here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which docs? The current demos use import * as NumberField from '@base_ui/react/NumberField';
as far as I can see.
const NumberFieldDemo = () => ( | ||
<NumberField.Root> | ||
<NumberField.Group> | ||
<NumberField.Decrement /> | ||
<NumberField.Input /> | ||
<NumberField.Increment /> | ||
</NumberField.Group> | ||
</NumberField.Root> | ||
); | ||
|
||
export default NumberFieldDemo; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we follow the convention in the docs, we would use:
const NumberFieldDemo = () => ( | |
<NumberField.Root> | |
<NumberField.Group> | |
<NumberField.Decrement /> | |
<NumberField.Input /> | |
<NumberField.Increment /> | |
</NumberField.Group> | |
</NumberField.Root> | |
); | |
export default NumberFieldDemo; | |
export default function NumberFieldDemo() { | |
return ( | |
<NumberField.Root> | |
<NumberField.Group> | |
<NumberField.Decrement /> | |
<NumberField.Input /> | |
<NumberField.Increment /> | |
</NumberField.Group> | |
</NumberField.Root> | |
); | |
} |
the main upside is to make it easier to add hooks, not having to refactor. But since it's not a demo, same point as a above, maybe it's a case where we want to make an exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep make an exception imo. Hooks are hugely deprioritised in new Base UI, so we should focus on simplicity in this example.
A quick clean-up of the getting started pages to focus things a bit more.
Preview: https://deploy-preview-329--base-ui.netlify.app/base-ui/getting-started/