Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Adding missing accessibility labels #33782

Merged
merged 8 commits into from Aug 10, 2022
Merged

[docs] Adding missing accessibility labels #33782

merged 8 commits into from Aug 10, 2022

Conversation

PunitSoniME
Copy link
Contributor

@PunitSoniME PunitSoniME commented Aug 3, 2022

Fixes #33781

Test changes here

@mui-bot
Copy link

mui-bot commented Aug 3, 2022

No bundle size changes

Generated by 🚫 dangerJS against 5abef20

@PunitSoniME
Copy link
Contributor Author

@oliviertassinari

Can you please review this one ?

Thanks

@mnajdova
Copy link
Member

mnajdova commented Aug 3, 2022

@PunitSoniME please share on the issue a description of what the problem really as. Also, can you provide some link to wai aria docs with more explanation for the changes related in the PR? Thanks!

@danilo-leal danilo-leal added docs Improvements or additions to the documentation accessibility a11y labels Aug 4, 2022
@PunitSoniME
Copy link
Contributor Author

PunitSoniME commented Aug 4, 2022

@mnajdova

Description added with links and fixes in the Issue - #33781

Copy link
Contributor Author

@PunitSoniME PunitSoniME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All requested changes done

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Thanks for the patience :)

@mnajdova mnajdova merged commit 0b9cae4 into mui:master Aug 10, 2022
@mnajdova mnajdova changed the title [docs] adding missing accessibility labels [docs] Adding missing accessibility labels Aug 10, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Adding missing accessibility labels
5 participants