Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Adding missing accessibility labels #33782

Merged
merged 8 commits into from
Aug 10, 2022
Merged

[docs] Adding missing accessibility labels #33782

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
40878a1
[docs] missing accessibility labels added
PunitSoniME Aug 3, 2022
f452865
[docs] missing accessibility labels added - prettier executed
PunitSoniME Aug 3, 2022
ae8edad
[docs] typescript prettier executed
PunitSoniME Aug 3, 2022
7e47394
Merge branch 'master' into fix/33781-missing-accessibility-labels
PunitSoniME Aug 4, 2022
428528e
[docs] requested changes done
PunitSoniME Aug 5, 2022
ba2bc40
[docs] requested changes done.
PunitSoniME Aug 6, 2022
6de682a
Merge branch 'master' into fix/33781-missing-accessibility-labels
PunitSoniME Aug 10, 2022
5abef20
[docs] aria-label updated for toggle-button platform
PunitSoniME Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/data/material/components/button-group/DisableElevation.js
View file
Open in desktop
Expand Up @@ -4,7 +4,11 @@ import Button from '@mui/material/Button';

export default function DisableElevation() {
return (
<ButtonGroup disableElevation variant="contained">
<ButtonGroup
disableElevation
variant="contained"
aria-label="Disabled elevation button"
>
<Button>One</Button>
<Button>Two</Button>
</ButtonGroup>
Expand Down
6 changes: 5 additions & 1 deletion docs/data/material/components/button-group/DisableElevation.tsx
View file
Open in desktop
Expand Up @@ -4,7 +4,11 @@ import Button from '@mui/material/Button';

export default function DisableElevation() {
return (
<ButtonGroup disableElevation variant="contained">
<ButtonGroup
disableElevation
variant="contained"
aria-label="Disabled elevation button"
PunitSoniME marked this conversation as resolved.
Show resolved Hide resolved
>
<Button>One</Button>
<Button>Two</Button>
</ButtonGroup>
Expand Down
6 changes: 5 additions & 1 deletion docs/data/material/components/button-group/DisableElevation.tsx.preview
View file
Open in desktop
@@ -1,4 +1,8 @@
<ButtonGroup disableElevation variant="contained">
<ButtonGroup
disableElevation
variant="contained"
aria-label="Disabled elevation button"
>
<Button>One</Button>
<Button>Two</Button>
</ButtonGroup>
6 changes: 3 additions & 3 deletions docs/data/material/components/floating-action-button/FloatingActionButtonExtendedSize.js
View file
Open in desktop
Expand Up @@ -6,15 +6,15 @@ import NavigationIcon from '@mui/icons-material/Navigation';
export default function FloatingActionButtonExtendedSize() {
return (
<Box sx={{ '& > :not(style)': { m: 1 } }}>
<Fab variant="extended" size="small" color="primary" aria-label="add">
<Fab variant="extended" size="small" color="primary" aria-label="extended">
<NavigationIcon sx={{ mr: 1 }} />
Extended
</Fab>
<Fab variant="extended" size="medium" color="primary" aria-label="add">
<Fab variant="extended" size="medium" color="primary" aria-label="extended">
<NavigationIcon sx={{ mr: 1 }} />
Extended
</Fab>
<Fab variant="extended" color="primary" aria-label="add">
<Fab variant="extended" color="primary" aria-label="extended">
PunitSoniME marked this conversation as resolved.
Show resolved Hide resolved
<NavigationIcon sx={{ mr: 1 }} />
Extended
</Fab>
Expand Down
6 changes: 3 additions & 3 deletions docs/data/material/components/floating-action-button/FloatingActionButtonExtendedSize.tsx
View file
Open in desktop
Expand Up @@ -6,15 +6,15 @@ import NavigationIcon from '@mui/icons-material/Navigation';
export default function FloatingActionButtonExtendedSize() {
return (
<Box sx={{ '& > :not(style)': { m: 1 } }}>
<Fab variant="extended" size="small" color="primary" aria-label="add">
<Fab variant="extended" size="small" color="primary" aria-label="extended">
<NavigationIcon sx={{ mr: 1 }} />
Extended
</Fab>
<Fab variant="extended" size="medium" color="primary" aria-label="add">
<Fab variant="extended" size="medium" color="primary" aria-label="extended">
<NavigationIcon sx={{ mr: 1 }} />
Extended
</Fab>
<Fab variant="extended" color="primary" aria-label="add">
<Fab variant="extended" color="primary" aria-label="extended">
<NavigationIcon sx={{ mr: 1 }} />
Extended
</Fab>
Expand Down
6 changes: 3 additions & 3 deletions ...a/material/components/floating-action-button/FloatingActionButtonExtendedSize.tsx.preview
View file
Open in desktop
@@ -1,12 +1,12 @@
<Fab variant="extended" size="small" color="primary" aria-label="add">
<Fab variant="extended" size="small" color="primary" aria-label="extended">
<NavigationIcon sx={{ mr: 1 }} />
Extended
</Fab>
<Fab variant="extended" size="medium" color="primary" aria-label="add">
<Fab variant="extended" size="medium" color="primary" aria-label="extended">
<NavigationIcon sx={{ mr: 1 }} />
Extended
</Fab>
<Fab variant="extended" color="primary" aria-label="add">
<Fab variant="extended" color="primary" aria-label="extended">
<NavigationIcon sx={{ mr: 1 }} />
Extended
</Fab>
11 changes: 1 addition & 10 deletions docs/data/material/components/slider/ColorSlider.js
View file
Open in desktop
Expand Up @@ -2,19 +2,10 @@ import * as React from 'react';
import Box from '@mui/material/Box';
import Slider from '@mui/material/Slider';

function valuetext(value) {
return `${value}°C`;
}

export default function ColorSlider() {
return (
<Box sx={{ width: 300 }}>
<Slider
aria-label="Temperature"
defaultValue={30}
getAriaValueText={valuetext}
color="secondary"
/>
<Slider aria-label="Color" defaultValue={30} color="secondary" />
PunitSoniME marked this conversation as resolved.
Show resolved Hide resolved
</Box>
);
}
11 changes: 1 addition & 10 deletions docs/data/material/components/slider/ColorSlider.tsx
View file
Open in desktop
Expand Up @@ -2,19 +2,10 @@ import * as React from 'react';
import Box from '@mui/material/Box';
import Slider from '@mui/material/Slider';

function valuetext(value: number) {
return `${value}°C`;
}

export default function ColorSlider() {
return (
<Box sx={{ width: 300 }}>
<Slider
aria-label="Temperature"
defaultValue={30}
getAriaValueText={valuetext}
color="secondary"
/>
<Slider aria-label="Color" defaultValue={30} color="secondary" />
</Box>
);
}
7 changes: 1 addition & 6 deletions docs/data/material/components/slider/ColorSlider.tsx.preview
View file
Open in desktop
@@ -1,6 +1 @@
<Slider
aria-label="Temperature"
defaultValue={30}
getAriaValueText={valuetext}
color="secondary"
/>
<Slider aria-label="Color" defaultValue={30} color="secondary" />
2 changes: 1 addition & 1 deletion docs/data/material/components/switches/ColorSwitches.js
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ const GreenSwitch = styled(Switch)(({ theme }) => ({
},
}));

const label = { inputProps: { 'aria-label': 'Switch demo' } };
const label = { inputProps: { 'aria-label': 'Color switch demo' } };

export default function ColorSwitches() {
return (
Expand Down
2 changes: 1 addition & 1 deletion docs/data/material/components/switches/ColorSwitches.tsx
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ const GreenSwitch = styled(Switch)(({ theme }) => ({
},
}));

const label = { inputProps: { 'aria-label': 'Switch demo' } };
const label = { inputProps: { 'aria-label': 'Color switch demo' } };

export default function ColorSwitches() {
return (
Expand Down
2 changes: 1 addition & 1 deletion docs/data/material/components/switches/SwitchesSize.js
View file
Open in desktop
@@ -1,7 +1,7 @@
import * as React from 'react';
import Switch from '@mui/material/Switch';

const label = { inputProps: { 'aria-label': 'Switch demo' } };
const label = { inputProps: { 'aria-label': 'Size switch demo' } };

export default function SwitchesSize() {
return (
Expand Down
2 changes: 1 addition & 1 deletion docs/data/material/components/switches/SwitchesSize.tsx
View file
Open in desktop
@@ -1,7 +1,7 @@
import * as React from 'react';
import Switch from '@mui/material/Switch';

const label = { inputProps: { 'aria-label': 'Switch demo' } };
const label = { inputProps: { 'aria-label': 'Size switch demo' } };

export default function SwitchesSize() {
return (
Expand Down
1 change: 1 addition & 0 deletions docs/data/material/components/toggle-button/ColorToggleButton.js
View file
Open in desktop
Expand Up @@ -15,6 +15,7 @@ export default function ColorToggleButton() {
value={alignment}
exclusive
onChange={handleChange}
aria-label="Color"
>
<ToggleButton value="web">Web</ToggleButton>
<ToggleButton value="android">Android</ToggleButton>
Expand Down
1 change: 1 addition & 0 deletions docs/data/material/components/toggle-button/ColorToggleButton.tsx
View file
Open in desktop
Expand Up @@ -18,6 +18,7 @@ export default function ColorToggleButton() {
value={alignment}
exclusive
onChange={handleChange}
aria-label="Color"
PunitSoniME marked this conversation as resolved.
Show resolved Hide resolved
>
<ToggleButton value="web">Web</ToggleButton>
<ToggleButton value="android">Android</ToggleButton>
Expand Down
1 change: 1 addition & 0 deletions docs/data/material/components/toggle-button/ColorToggleButton.tsx.preview
View file
Open in desktop
Expand Up @@ -3,6 +3,7 @@
value={alignment}
exclusive
onChange={handleChange}
aria-label="Color"
>
<ToggleButton value="web">Web</ToggleButton>
<ToggleButton value="android">Android</ToggleButton>
Expand Down
8 changes: 5 additions & 3 deletions docs/data/material/components/toggle-button/ToggleButtonSizes.js
View file
Open in desktop
Expand Up @@ -45,11 +45,13 @@ export default function ToggleButtonSizes() {
'& > :not(style) + :not(style)': { mt: 2 },
}}
>
<ToggleButtonGroup size="small" {...control}>
<ToggleButtonGroup size="small" {...control} aria-label="Small sizes">
{children}
</ToggleButtonGroup>
<ToggleButtonGroup {...control}>{children}</ToggleButtonGroup>
<ToggleButtonGroup size="large" {...control}>
<ToggleButtonGroup {...control} aria-label="Medium sizes">
{children}
</ToggleButtonGroup>
<ToggleButtonGroup size="large" {...control} aria-label="Large sizes">
{children}
</ToggleButtonGroup>
</Box>
Expand Down
8 changes: 5 additions & 3 deletions docs/data/material/components/toggle-button/ToggleButtonSizes.tsx
View file
Open in desktop
Expand Up @@ -48,11 +48,13 @@ export default function ToggleButtonSizes() {
'& > :not(style) + :not(style)': { mt: 2 },
}}
>
<ToggleButtonGroup size="small" {...control}>
<ToggleButtonGroup size="small" {...control} aria-label="Small sizes">
{children}
</ToggleButtonGroup>
<ToggleButtonGroup {...control}>{children}</ToggleButtonGroup>
<ToggleButtonGroup size="large" {...control}>
<ToggleButtonGroup {...control} aria-label="Medium sizes">
{children}
</ToggleButtonGroup>
<ToggleButtonGroup size="large" {...control} aria-label="Large sizes">
{children}
</ToggleButtonGroup>
</Box>
Expand Down
8 changes: 5 additions & 3 deletions docs/data/material/components/toggle-button/ToggleButtonSizes.tsx.preview
View file
Open in desktop
@@ -1,7 +1,9 @@
<ToggleButtonGroup size="small" {...control}>
<ToggleButtonGroup size="small" {...control} aria-label="Small sizes">
{children}
</ToggleButtonGroup>
<ToggleButtonGroup {...control}>{children}</ToggleButtonGroup>
<ToggleButtonGroup size="large" {...control}>
<ToggleButtonGroup {...control} aria-label="Medium sizes">
{children}
</ToggleButtonGroup>
<ToggleButtonGroup size="large" {...control} aria-label="Large sizes">
{children}
</ToggleButtonGroup>