New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Enforce 70 as the max width on the title on the docs #33819
[core] Enforce 70 as the max width on the title on the docs #33819
Conversation
f918a10
to
d3bc1cc
Compare
d3bc1cc
to
7a27029
Compare
60 feels too restrictive for sure. I'm actually surprised that 50-60 is the recommendation. 70 max feels like a solid goal, but maybe it's nice to have an extra 5 characters for wiggle room? For example "Our docs just got a major upgrade—here's what that means for you" feels good to me at 72, but it could be awkward to try to condense it to <70. |
@samuelsycamore Yes agree, this way we can learn, we will have a feedback loop. In your example, if "Our docs just got a major upgrade—here's what that means for you" was indeed 72 characters, then the CI must have been red ❌, but it was green ✅: so something was not making sense. Hence why I have tested it in #33819 (comment) to debug. |
A title too long issue was reported in https://app.ahrefs.com/site-audit/3524616/24/data-explorer?columns=pageRating%2Curl%2Ctraffic%2ChttpCode%2Cdepth%2Ctitle%2CtitlesLength%2CnrTitles%2Ccompliant&filterCollapsed=true&filterId=0f7e22d4a95d6f7840cd16096f4006c1&issueId=c64dac3a-d0f4-11e7-8ed1-001e67ed4656
At first, I was reluctant to enforce it, but in this example, it feels too long. I have proposed a new title that I feel goes quicker to the important message. While ahrefs recommends 60 characters, I have found blog posts that can hardly be shorter, e.g. https://blog.logrocket.com/build-type-safe-version-tailwind-css-sprinkles/ hence 70
The error message feels like this: