Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Enforce 70 as the max width on the title on the docs #33819

Merged
merged 3 commits into from Aug 13, 2022
Merged

[core] Enforce 70 as the max width on the title on the docs #33819

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a27029
[docs] Enforce a max width on the title
oliviertassinari Aug 6, 2022
393f1c4
Be less restrictive
oliviertassinari Aug 11, 2022
28a8600
Polishes
oliviertassinari Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/packages/markdown/parseMarkdown.js
View file
Open in desktop
Expand Up @@ -394,6 +394,16 @@ function prepareMarkdown(config) {
throw new Error(`Missing title in the page: ${location}`);
}

if (title.length > 70) {
throw new Error(
[
`The title "${title}" is too long (${title.length} characters).`,
'It needs to have fewer than 70 characters, ideally less than 60, see for more details:',
oliviertassinari marked this conversation as resolved.
Show resolved Hide resolved
'https://developers.google.com/search/docs/advanced/appearance/title-link',
].join('\n'),
);
}

if (description == null || description === '') {
throw new Error(`Missing description in the page: ${location}`);
}
Expand Down
8 changes: 4 additions & 4 deletions docs/pages/blog/lab-date-pickers-to-mui-x.md
View file
Open in desktop
@@ -1,6 +1,6 @@
---
title: MUI X expands its product line with advanced date and time picker components
description: Migrate to the new package to start building with our powerful date and time pickers, now part of MUI X.
title: Date and time pickers are moving to MUI X
description: Migrate to the new package to start building with our powerful date and time pickers, now part of MUI X. Previously released MIT components stayed MIT.
oliviertassinari marked this conversation as resolved.
Show resolved Hide resolved
date: 2022-04-03T00:00:00.000Z
authors: ['flaviendelangle']
tags: ['MUI X', 'News']
Expand All @@ -13,7 +13,7 @@ This means we'll be dedicating even more time and effort to these complex compon
## TL;DR

- The date pickers are one step closer to a stable release.
- **No surprise licenses changes**. We are staying true to [our promises](https://mui-org.notion.site/Stewardship-542a2226043d4f4a96dfb429d16cf5bd). What's MIT stays MIT, and what was [announced](https://v5-0-6.mui.com/components/date-range-picker/) over 12 months ago to move to a commercial license move.
- **No surprise licenses changes**. We are staying true to [our promises](https://mui-org.notion.site/Stewardship-542a2226043d4f4a96dfb429d16cf5bd). What's MIT stays MIT, and what was [announced](https://v5-0-6.mui.com/components/date-range-picker/) over 12 months ago to move to a commercial license for the range feature.
oliviertassinari marked this conversation as resolved.
Show resolved Hide resolved
- Follow the [migration steps](/x/react-date-pickers/migration-lab/)

## What are date and time pickers?
Expand All @@ -32,7 +32,7 @@ The user may need to select an individual date/time, or a range.

[MUI X](/x/) is a collection of advanced components built for complex use cases.

As opposed to the Core library, which leans on the open-source community for support, MUI X components require several full-time developers dedicated to engineering and ongoing maintenance.
As opposed to the MUI Core library, which leans on the open-source community for support, MUI X components require several full-time developers dedicated to engineering and ongoing maintenance.

MUI X components are available under two licenses:

Expand Down