[docs] Add CSS variables documentation for Material UI #33958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/css-variables
…/css-variables
1 task
|
I think "CSS theme variables" (lowercase t) is a good term for this. 👍 |
|
Great job @siriwatknp! I'll follow up with suggestions for style and grammar but overall the content and structure look great. |
docs/data/material/experimental-api/css-theme-variables/customization.md
Outdated
Show resolved
Hide resolved
docs/data/material/experimental-api/css-theme-variables/customization.md
Outdated
Show resolved
Hide resolved
docs/data/material/experimental-api/css-theme-variables/customization.md
Outdated
Show resolved
Hide resolved
docs/data/material/experimental-api/css-theme-variables/overview.md
Outdated
Show resolved
Hide resolved
docs/data/material/experimental-api/css-theme-variables/overview.md
Outdated
Show resolved
Hide resolved
docs/data/material/experimental-api/css-theme-variables/usage.md
Outdated
Show resolved
Hide resolved
docs/data/material/experimental-api/css-theme-variables/usage.md
Outdated
Show resolved
Hide resolved
docs/data/material/experimental-api/css-theme-variables/usage.md
Outdated
Show resolved
Hide resolved
docs/data/material/experimental-api/css-theme-variables/usage.md
Outdated
Show resolved
Hide resolved
docs/data/material/experimental-api/css-theme-variables/usage.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
samuelsycamore
approved these changes
Sep 29, 2022
alexfauquette
pushed a commit
to alexfauquette/material-ui
that referenced
this pull request
Oct 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #33417
Preview: https://deploy-preview-33958--material-ui.netlify.app/material-ui/experimental-api/css-theme-variables/overview/
The page structure follows the RFC
I think that the word
CSS variablesis too broad which refers to CSS rather than the feature that we implement.What Material UI offers is related to the CSS variables generated from the theme, so I think using
Theme CSS variablessounds better. (another option could beCSS Theme variables) cc @samuelsycamoreWhat's next
There are other advanced topics that I haven't covered but I think it is better to move them into a separate PR.
:whereselector