Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy][Menu] Set disablePortal default to false #34283

Merged
merged 3 commits into from Sep 15, 2022

Conversation

tomasz-sodzawiczny
Copy link
Contributor

@tomasz-sodzawiczny tomasz-sodzawiczny commented Sep 12, 2022

Fixes #34239.

Note that this might be a breaking change.

@mui-bot
Copy link

mui-bot commented Sep 12, 2022

Details of bundle changes

Generated by 🚫 dangerJS against 22491a9

@siriwatknp siriwatknp added the package: joy-ui Specific to @mui/joy label Sep 12, 2022
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your contribution! I updated the zIndex to be the same as Material UI Menu (it prevents the overlapping in the demo)

@danilo-leal danilo-leal added the component: menu This is the name of the generic UI component, not the React module! label Sep 15, 2022
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for contributing!

@siriwatknp siriwatknp merged commit bde27f8 into mui:master Sep 15, 2022
@siriwatknp siriwatknp changed the title [Joy][menu] Set disablePortal default to false [Joy][Menu] Set disablePortal default to false Sep 15, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Joy][menu] disablePortal={true} is set by default on PopperUnstyled
4 participants