Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Joy][Menu] Set disablePortal default to false #34283

Merged
merged 3 commits into from Sep 15, 2022
Merged

[Joy][Menu] Set disablePortal default to false #34283

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61720ab
[Joy][menu] Set disablePortal default to false
tomasz-sodzawiczny Sep 12, 2022
29f4d81
Merge branch 'master' of https://github.com/mui/material-ui into issu…
siriwatknp Sep 13, 2022
22491a9
fix zIndex
siriwatknp Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/mui-joy/src/Menu/Menu.tsx
View file
Open in desktop
Expand Up @@ -43,7 +43,7 @@ const MenuRoot = styled(ListRoot, {
...scopedVariables,
boxShadow: theme.vars.shadow.md,
overflow: 'auto',
zIndex: 1000,
zIndex: 1300, // the same value as Material UI Menu. TODO: revisit the appropriate value later.
...(!variantStyle?.backgroundColor && {
backgroundColor: theme.vars.palette.background.surface,
}),
Expand All @@ -62,7 +62,7 @@ const Menu = React.forwardRef(function Menu(inProps, ref) {
children,
component,
color = 'neutral',
disablePortal = true,
disablePortal = false,
keepMounted = false,
id,
onClose,
Expand Down