[Modal] Make the initial "exited" state to dependent on "open" #35010
Conversation
|
sai6855
changed the title
|
Hey @mnajdova any reason this pr is not being reviewed, I'm happy to implement whatever changes are required |
There was a problem hiding this comment.
Sorry for the delay. Changes look great, I could validate that it works here: https://codesandbox.io/s/wonderful-lumiere-sqf133?file=/package.json
Can we please add a test before merging? We could create an open modal with a custom slots.root component and validate that the exited prop has the correct value.
mnajdova
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
|
Hey @mnajdova I've added test as described, this is pr ready for review |
ZeeshanTamboli
added
bug 🐛
|
Hi Team, Can we please merge this change, looks like its passing all test cases and good to go, I was facing the same issue and this PR came close to my issue, thanks @sai6855 for fixing the bug. |
|
Hey @mnajdova, would it be possible to have a second quick look at this one please ? 🙏 |
|
@ZeeshanTamboli can you review this pr |
ZeeshanTamboli
removed
the
component: drawer
…ue (mui#35010) Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Fixes: #34999
exited state was defaulted to true in ModalUnstyled.tsx, but if initial state of open is true and exited is true then closing animation is not being applied. So I've made initial state of exited to be dependent on open .
After fix: https://codesandbox.io/s/eager-river-0yloeh?file=/src/App.js