Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Inform that pickers are in X repository #35189

Merged
merged 2 commits into from Nov 18, 2022

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Nov 18, 2022

@alexfauquette alexfauquette added the docs Improvements or additions to the documentation label Nov 18, 2022
@mui-bot
Copy link

mui-bot commented Nov 18, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-35189--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 23aed3a

Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
@alexfauquette alexfauquette merged commit 08db62a into mui:master Nov 18, 2022
@alexfauquette alexfauquette deleted the fix-migration branch November 18, 2022 11:19
@@ -2,6 +2,12 @@

<p class="description">@material-ui/pickers was moved to the @mui/lab.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would make sense to update the page to remove all mentions of @mui/lab. Since there are no breaking changes with the migration of the lab to MUI X. I guess we could encourage the developers to directly start there, so to update the imports on this page to point @mui/x-date-pickers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no breaking changes with the migration of the lab to MUI X.

We just have the import breaking change (default to named)

@@ -2,6 +2,12 @@

<p class="description">@material-ui/pickers was moved to the @mui/lab.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no breaking changes with the migration of the lab to MUI X.

We just have the import breaking change (default to named)

@@ -2,6 +2,12 @@

<p class="description">@material-ui/pickers was moved to the @mui/lab.</p>

:::info
**Stable package available**: The pickers are not available in `@mui/lab`after `v5.0.0-alpha.89`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Stable package available**: The pickers are not available in `@mui/lab`after `v5.0.0-alpha.89`.
**Stable package available**: The pickers are not available in `@mui/lab` after `v5.0.0-alpha.89`.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I include the fix in an unrelated PR

@oliviertassinari oliviertassinari added the component: pickers This is the name of the generic UI component, not the React module! label Nov 19, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants