Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Inform that pickers are in X repository #35189

Merged
merged 2 commits into from Nov 18, 2022
Merged

[docs] Inform that pickers are in X repository #35189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae0996b
[docs] Inform that pickers are in X repo
alexfauquette Nov 18, 2022
23aed3a
Update docs/data/material/guides/pickers-migration/pickers-migration.md
alexfauquette Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/data/material/guides/pickers-migration/pickers-migration.md
View file
Open in desktop
Expand Up @@ -2,6 +2,12 @@

<p class="description">@material-ui/pickers was moved to the @mui/lab.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would make sense to update the page to remove all mentions of @mui/lab. Since there are no breaking changes with the migration of the lab to MUI X. I guess we could encourage the developers to directly start there, so to update the imports on this page to point @mui/x-date-pickers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no breaking changes with the migration of the lab to MUI X.

We just have the import breaking change (default to named)


:::info
**Stable package available**: The pickers are not available in `@mui/lab`after `v5.0.0-alpha.89`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Stable package available**: The pickers are not available in `@mui/lab`after `v5.0.0-alpha.89`.
**Stable package available**: The pickers are not available in `@mui/lab` after `v5.0.0-alpha.89`.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I include the fix in an unrelated PR

They have been moved from `@mui/lab` to the MUI X packages `@mui/x-date-pickers` and `@mui/x-date-pickers-pro`.
To migrate from `@mui/lab` to `@mui/x-date-pickers` you can follow the dedicated [migration guide](/x/react-date-pickers/migration-lab/).
:::

:::warning
**⚠️ The date picker components were rewritten**. In most places, the logic was rewritten from scratch, so it isn't possible to maintain the whole list of changes. Here's an overview of the most important concepts that were changed. If you are going to upgrade, the easiest way might be to go through each picker usage in your codebase, and rewrite them one at a time. Don't forget to run your tests after each!
:::
Expand Down