[docs] Improve Multiselect demo styling #37120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
docs
Netlify deploy previewhttps://deploy-preview-37120--material-ui.netlify.app/ Bundle size report |
siriwatknp
approved these changes
May 1, 2023
binh1298
pushed a commit
to binh1298/material-ui
that referenced
this pull request
May 17, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the look of multiple selected options in Base UI's Select demos.
Before:
After:
This relies on the
:hasCSS selector and won't currently work on Firefox (it'll look like before).Interestingly, I couldn't make it work by writing&.${optionClasses.selected}:has(+ .${optionClasses.selected}), as for some reason, Emotion was transforming this into&:has(+ .MuiSelected). I wasn't able to isolate this issue, though.I discussed the issue with @siriwatknp, who proposed a fix in createEmotionCache that I included in the PR.