[docs] Fix branding theme tabs and navigation bar regressions #37362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-37362--material-ui.netlify.app/ Bundle size report |
ZeeshanTamboli
changed the title
Tabs and Navigation bar regressionTabs and Navigation bar regression
ZeeshanTamboli
commented
May 22, 2023
ZeeshanTamboli
changed the title
Tabs and Navigation bar regressionTabs and Navigation bar regressions
mnajdova
reviewed
May 22, 2023
ZeeshanTamboli
changed the title
Tabs and Navigation bar regressionsTabs and Navigation bar regressions
ZeeshanTamboli
changed the title
Tabs and Navigation bar regressions
|
@ZeeshanTamboli Great! Thanks for fixing this. |
siriwatknp
reviewed
May 23, 2023
2 tasks
…emove prepending className
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-37362--material-ui.netlify.app/
Fix the following regressions reported in Slack:
Nav.Bar.Hover.Regression.mov
For regressions 1 and 2, it was because in the branding theme, the Tab component styles were being overridden globally. It was done for the Base UI documentation tab in #35938 (see the diff), but it affected the Home and Pricing pages. The branding theme is used by the
BrandingCssVarsProvider, which is used in the Home, Pricing and other pages. The solution was to apply the styles for the Base UI tabs in it's own context inComponentPageTabsusing the sx prop.For regression 3, see explanation below. Fixes #37368