[Table] Use stable context API #13529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
the
component: table
eps1lon
commented
Nov 6, 2018
| } | ||
| function TableBody(props) { | ||
| const { classes, className, component: Component, ...other } = props; | ||
| const childContext = { variant: 'body' }; |
There was a problem hiding this comment.
As an easy perf optimization I would suggest moving this to a string only. Otherwise a rerender of TableBody will trigger a rerender of every context consumer since strict equality is used for rerender check.
Already included the perf optimization
oliviertassinari
force-pushed
the
fix/core/Table/stable-context
branch
2 times, most recently
from
c2aa160
to
a964103
Compare
oliviertassinari
force-pushed
the
fix/core/Table/stable-context
branch
from
a964103
to
9a59daf
Compare
|
@eps1lon A quick benchmark on server side. I think that we are good to go.
|
oliviertassinari
approved these changes
Nov 8, 2018
|
Good job here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13394.
Only form and theme context left. Theme will be addressed by #13503. I'm working on the form.