Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Include innerRef breaking change in changelog #14771

Merged
merged 2 commits into from
Mar 6, 2019
Merged

[docs] Include innerRef breaking change in changelog #14771

merged 2 commits into from
Mar 6, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Mar 6, 2019

Closes #14766

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Mar 6, 2019
@VincentLanglet
Copy link
Contributor

A word about the impact this can have on snapshots could be useful to avoid others issues like mine.

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 6, 2019 •
edited

No bundle size changes comparing 7a49f80...024d668

Generated by 🚫 dangerJS against 024d668

@eps1lon
Copy link
Member Author

eps1lon commented Mar 6, 2019

A word about the impact this can have on snapshots could be useful to avoid others issues like mine.

@VincentLanglet Is 024d668 sufficient?

@VincentLanglet
Copy link
Contributor

@eps1lon Yes.
Before creating the issue I opened the Changelog and search for snapshot and forwardRef keywords. So it's perfect

@oliviertassinari
Copy link
Member

It would also be great to document the forwardRef breaking change in the v3 to v4 migration guide. I don't remember adding it.

@eps1lon
Copy link
Member Author

eps1lon commented Mar 6, 2019

It would also be great to document the forwardRef breaking change in the v3 to v4 migration guide. I don't remember adding it.

It's not quite complete yet. I'll add a note to #14415 and do a quick write up once it's ready.

@eps1lon eps1lon merged commit 7c3a016 into mui:next Mar 6, 2019
@eps1lon eps1lon deleted the docs/changelog-breaking branch March 6, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
breaking change docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eps1lon @VincentLanglet @mui-pr-bot @oliviertassinari