Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MenuList] Convert to a function component #14865

Merged
merged 18 commits into from Mar 21, 2019
Merged

[MenuList] Convert to a function component #14865

merged 18 commits into from Mar 21, 2019

Commits on Mar 13, 2019

  1. [MenuList] Convert to a function component 

    * Provide access to MenuList internals via actions property

* Changed Menu to interact with MenuList only via exposed actions

* Adjusted Menu and MenuList tests accordingly
    @ryancogswell
    ryancogswell committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    62dde3d View commit details
    Browse the repository at this point in the history

  2. [MenuList] Fix MenuList test expected results to account for varying … 

    …scrollbar size

* scrollbar size is 0px with jsdom, but various sizes in Karma tests with different browsers
    @ryancogswell
    ryancogswell committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    ce48173 View commit details
    Browse the repository at this point in the history

  3. [MenuList] Address lint errors 

    * Moved resetTabIndex out of the component so it doesn't need to be an effect dependency

* Removed no-longer-used (due to moving functionality to MenuList) imports from Menu
    @ryancogswell
    ryancogswell committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    47ec9dc View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. [MenuList] Incorporate code review feedback 

    * Deconstruct props in function body

* Remove redundant findDOMNode calls

* Document StrictMode status of findDOMNode calls
    @ryancogswell
    ryancogswell committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    1d9b3fa View commit details
    Browse the repository at this point in the history

  2. [MenuList] Fix Karma test for Safari (hopefully) 

    * Unable to test this locally
    @ryancogswell
    ryancogswell committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    db16f8e View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2019

  1. [MenuList] Fix Karma test for Mac OS Chrome (hopefully) 

    * Unable to test this locally
    @ryancogswell
    ryancogswell committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    8d3276d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into menulist-func-comp

    @ryancogswell
    ryancogswell committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    2102221 View commit details
    Browse the repository at this point in the history

  3. [MenuList] Use getScrollbarSize from utils instead of dom-helpers

    @ryancogswell
    ryancogswell committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    85c4b47 View commit details
    Browse the repository at this point in the history

  4. [MenuList] Prettier

    @ryancogswell
    ryancogswell committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    4bedf09 View commit details
    Browse the repository at this point in the history

  5. [MenuList] Fix Karma test for Chrome 41 (hopefully)

    @ryancogswell
    ryancogswell committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    ff24cc2 View commit details
    Browse the repository at this point in the history

  6. [MenuList] Fix Karma test for Chrome 41 

    * Stub clientHeight by stubbing the getter (stubbing the value does not work on Chrome 41)
    @ryancogswell
    ryancogswell committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    93e1f82 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2019

  1. Merge branch 'next' into menulist-func-comp

    @ryancogswell
    ryancogswell committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    8267c33 View commit details
    Browse the repository at this point in the history

  2. [MenuList] Support ref using forwardRef 

    * Change test to use ref instead of wrapper.getDOMNode()
    @ryancogswell
    ryancogswell committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    4517661 View commit details
    Browse the repository at this point in the history

  3. [MenuList] Prettier test

    @ryancogswell
    ryancogswell committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    efd358e View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. [test] Remove wrapper.setProps calls for specifying onEnteringSpy

    @ryancogswell
    ryancogswell committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    c88b8b1 View commit details
    Browse the repository at this point in the history

  2. [MenuList] Make intent of condition clearer

    @ryancogswell
    ryancogswell committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    027452a View commit details
    Browse the repository at this point in the history

  3. [MenuList] Change useLayoutEffect to useEffect

    @ryancogswell
    ryancogswell committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    caf861a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'next' into menulist-func-comp

    @ryancogswell
    ryancogswell committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    defd2d3 View commit details
    Browse the repository at this point in the history