Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Clarify transform-runtime, runtime version #18512

Merged
merged 1 commit into from Jan 20, 2020
Merged

[build] Clarify transform-runtime, runtime version #18512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion babel.config.js
View file
Open in desktop
Expand Up @@ -44,7 +44,8 @@ module.exports = {
'babel-plugin-optimize-clsx',
['@babel/plugin-proposal-class-properties', { loose: true }],
['@babel/plugin-proposal-object-rest-spread', { loose: true }],
'@babel/plugin-transform-runtime',
// any package needs to declare 7.4.4 as a runtime dependency. default is ^7.0.0
['@babel/plugin-transform-runtime', { version: '^7.4.4' }],
// for IE 11 support
'@babel/plugin-transform-object-assign',
],
Expand Down
11 changes: 10 additions & 1 deletion docs/babel.config.js
View file
Open in desktop
@@ -1,4 +1,5 @@
const bpmr = require('babel-plugin-module-resolver');
const fse = require('fs-extra');

function resolvePath(sourcePath, currentFile, opts) {
if (sourcePath === 'markdown') {
Expand All @@ -22,8 +23,16 @@ const alias = {
pages: './pages',
};

const { version: transformRuntimeVersion } = fse.readJSONSync(
require.resolve('@babel/runtime-corejs2/package.json'),
);

module.exports = {
presets: ['next/babel', '@zeit/next-typescript/babel'],
presets: [
// backport of https://github.com/zeit/next.js/pull/9511
['next/babel', { 'transform-runtime': { corejs: 2, version: transformRuntimeVersion } }],
'@zeit/next-typescript/babel',
],
plugins: [
'babel-plugin-optimize-clsx',
// for IE 11 support
Expand Down
2 changes: 2 additions & 0 deletions docs/package.json
View file
Open in desktop
Expand Up @@ -19,6 +19,7 @@
"dependencies": {
"@babel/core": "^7.7.4",
"@babel/plugin-transform-object-assign": "^7.7.4",
"@babel/runtime-corejs2": "^7.8.3",
"@date-io/core": "^1.3.9",
"@date-io/date-fns": "^1.3.11",
"@emotion/core": "^10.0.27",
Expand Down Expand Up @@ -70,6 +71,7 @@
"fg-loadcss": "^2.0.1",
"final-form": "^4.18.5",
"flexsearch": "^0.6.30",
"fs-extra": "^8.1.0",
"isomorphic-fetch": "^2.2.1",
"json2mq": "^0.2.0",
"jss": "^10.0.3",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Expand Up @@ -830,7 +830,7 @@
pirates "^4.0.0"
source-map-support "^0.5.16"

"@babel/runtime-corejs2@7.1.2", "@babel/runtime-corejs2@^7.4.4", "@babel/runtime-corejs2@^7.7.4":
"@babel/runtime-corejs2@7.1.2", "@babel/runtime-corejs2@^7.4.4", "@babel/runtime-corejs2@^7.7.4", "@babel/runtime-corejs2@^7.8.3":
version "7.8.3"
resolved "https://registry.yarnpkg.com/@babel/runtime-corejs2/-/runtime-corejs2-7.8.3.tgz#b62a61e0c41a90d2d91181fda6de21cecd3a9734"
integrity sha512-yxJXBKdIogkfF+wgeJrvU7Afp5ugBi92NzSgNPWWKVoQAlixH3gwMP6yYYr7SV1Dbc0HmNw7WUJkV5ksvtQuHg==
Expand Down