Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Use node 10 in every CI/CD pipeline #19301

Merged
merged 3 commits into from
Jan 19, 2020
Merged

[core] Use node 10 in every CI/CD pipeline #19301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09bd18e
[core] Use node 10 in every CI/CD pipeline
eps1lon Jan 19, 2020
ed9cdc6
dubnium -> 10
eps1lon Jan 19, 2020
6f21469
[docs] Clarify supported node version
eps1lon Jan 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ defaults: &defaults
REACT_DIST_TAG: << parameters.react-dist-tag >>
working_directory: /tmp/material-ui
docker:
- image: circleci/node:8.16
- image: circleci/node:10
# CircleCI has disabled the cache across forks for security reasons.
# Following their official statement, it was a quick solution, they
# are working on providing this feature back with appropriate security measures.
Expand All @@ -24,6 +24,11 @@ defaults: &defaults
commands:
install_js:
steps:
- run:
name: View install environment
command: |
node --version
yarn --version
- run:
name: Resolve react version
command: |
Expand Down Expand Up @@ -154,7 +159,7 @@ jobs:
test_regressions:
<<: *defaults
docker:
- image: circleci/node:8.16
- image: circleci/node:10
- image: selenium/standalone-chrome:3.11.0
steps:
- checkout
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/getting-started/supported-platforms/supported-platforms.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ You can expect Material-UI's components to render without major issues.
## Server

Because Material-UI supports server-side rendering, it needs to support the latest, stable releases of [Node.js](https://github.com/nodejs/node).
Where possible, the [LTS versions that are in maintenance](https://github.com/nodejs/Release#lts-schedule1) are supported. Right now, it supports **node v8.x** and newer versions.
Where possible, the [LTS versions that are in maintenance](https://github.com/nodejs/Release#lts-schedule1) are supported. We recommend using **node v10.x** or newever. However we still support **node v8.x**. The support of **node v8.x** will be stopped in Material-UI Version 5.

### CSS prefixing

Expand Down