[test] Update react next patch #21746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Jul 10, 2020
| diff --git a/packages/material-ui/src/Unstable_TrapFocus/Unstable_TrapFocus.js b/packages/material-ui/src/Unstable_TrapFocus/Unstable_TrapFocus.js | ||
| index 97fac726d..e43c9f5d4 100644 | ||
| --- a/packages/material-ui/src/Unstable_TrapFocus/Unstable_TrapFocus.js | ||
| +++ b/packages/material-ui/src/Unstable_TrapFocus/Unstable_TrapFocus.js |
There was a problem hiding this comment.
Can't come up with a reliable isolated test for this change so this stays strictly in this patch for now. There's definitely an issue with testing-library (we probably need to use a fork of cleanup because the new one is not explained and targetted at jest) and likely an issue with JSDOM.
There was a problem hiding this comment.
Also very likely that there's an issue on our end. In the end we're reaching into a lot of internals.
|
No bundle size changes comparing 44f00aa...83ab6f6 |
eps1lon
force-pushed
the
test/update-react-next-patch
branch
from
c6f0963
to
811d5ae
Compare
github-actions
bot
added
the
PR: out-of-date
eps1lon
force-pushed
the
test/update-react-next-patch
branch
from
811d5ae
to
dcbf778
Compare
eps1lon
removed
the
PR: out-of-date
eps1lon
force-pushed
the
test/update-react-next-patch
branch
from
a77f146
to
12280e6
Compare
eps1lon
force-pushed
the
test/update-react-next-patch
branch
from
12280e6
to
83ab6f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not fix test failures yet. Will look into that later.
Forward ports
react-next.diffwhich requires@testing-library/react@^10.4.7(specifically testing-library/react-testing-library#746).How to:
git checkout -b test/update-react-next-patchgit apply scripts/react-next.diffnext:git rebase nextgit diff HEAD^! > rext-next.new.diffscripts/react-next.diffwithrext-next.new.diffThis only explains how to forward port. For fixing tests on
react@nextuseREACT_DIST_TAG=next node scripts/use-react-dist-tag.jsand start fixing failures.