[test] Convert remaining enzyme tests to testing-library #26832
Conversation
| ); | ||
| expect(wrapper.text()).to.equal(''); | ||
|
|
||
| expect(container.firstChild).to.equal(null); |
There was a problem hiding this comment.
Argueably a clearer assertion since there's a different between an element with no text and no element.
As part of describeConformance i.e. strictly internal |
Ok, so we could potentially accept a PR that rewrites the |
A big "If" though. I don't understand why this is important though. I wouldn't waste a second thinking about dropping enzyme. |
|
@eps1lon Ok, thanks for the extra input. I wouldn't say it's important. I was wondering about the contingency plan in case of enzyme prevents us to upgrade React: enzymejs/enzyme#2524 (comment). |
|
In the past we just forked the adapter which is fairly straight forward for the set of features we need. So there's no point in being concerned about this right now. Especially since the 17 adapter works just fine with React 18 alpha. |
This removes direct usage of enzyme from our internal testing API. It'll be only used internally-internally (i.e. not by collaborators writing tests but collaborators working on the testing API).
Testing with enzyme is still valueable for us. It was just too easy to write bad tests with enzyme.
This'll make it easier to debug these tests in React 18
Closes #22911