[CalendarPicker] Use transition components from core instead of a custom implementation #27043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
the
component: pickers
|
Details of bundle changes (experimental) @material-ui/lab: parsed: -0.14% 😍, gzip: +0.14% |
1 task
eps1lon
changed the title
eps1lon
force-pushed
the
fix/CalendarPicker/StrictMode
branch
from
17e63f2
to
f45f814
Compare
eps1lon
force-pushed
the
fix/CalendarPicker/StrictMode
branch
from
f45f814
to
c9d5b08
Compare
|
The transition is not working. I think that it would be better to have no transitions than the current UX: PR broken.transition.mp4https://deploy-preview-27043--material-ui.netlify.app/components/date-picker/ HEAD ok.mp4https://deploy-preview-27043--material-ui.netlify.app/components/date-picker/ Baseline baseline.mp4 |
|
Please file a proper bug report. How can I teach you this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The visuals might've slightly changed for fading but the implementation is now a lot simpler. Devs expecting that a customization of Fade affects every fade-like transition are no longer surprised.
We can't apply the same pattern to the sliding transition since it has different directions for enter an d exit which our Slide doesn't support as far as I can tell.
https://deploy-preview-27043--material-ui.netlify.app/components/date-picker/