Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Grid] Fix prop check for applying wrap-reverse #30813

Merged
merged 4 commits into from Jan 31, 2022
Merged

[Grid] Fix prop check for applying wrap-reverse #30813

merged 4 commits into from Jan 31, 2022

Conversation

Hubbz
Copy link
Contributor

@Hubbz Hubbz commented Jan 27, 2022 •
edited by hbjORbj

Closes #30812

@mui-bot
Copy link

mui-bot commented Jan 27, 2022 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against b41917d

@hbjORbj hbjORbj added component: Grid The React component. package: material-ui Specific to @mui/material bug 🐛 Something doesn't work labels Jan 28, 2022
@hbjORbj
Copy link
Member

hbjORbj commented Jan 28, 2022

Hi.

Thanks for opening the PR.

I can confirm in this codesandbox that the issue is fixed.

Can you add a unit test to prevent this bug from happening again in the future?

@Hubbz
Copy link
Contributor Author

Hubbz commented Jan 28, 2022

No problemo. Unit test has been added. Cheers.

@oliviertassinari
Copy link
Member

I have pushed a simplification and took a note for v6 (in #30660). We probably want to encourage developers to use flexWrap moving forward: https://mui.com/system/flexbox/#flex-wrap.

@oliviertassinari oliviertassinari added the regression A bug, but worse label Jan 28, 2022
mnajdova
mnajdova approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@mnajdova mnajdova merged commit 29b9ee8 into mui:master Jan 31, 2022
@Hubbz Hubbz deleted the 30812-grid-wrap-styling-is-not-applying-when-wrap-reverse-is-used branch January 31, 2022 16:34
wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
@Hubbz @wladimirguerra
[Grid] Fix prop check for applying wrap-reverse (mui#30813)
e29106b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: Grid The React component. package: material-ui Specific to @mui/material regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Grid] wrap='wrap-reverse' is not applying
5 participants
@Hubbz @mui-bot @hbjORbj @oliviertassinari @mnajdova