[Transition] Add sx prop type

[cvanem]

No description provided.

[ivan-ngchakming]

Hello, I think you forgot to run yarn proptypes to add the sx props to Slide's proptypes.
I believe you also need to regenerate the docs using yarn docs:api too.

[mnajdova]

The transition components does not support the sx prop. The sx prop should be used in the inner component (the component they wrap and add the transition).

If this is not clear, maybe we can re-purpose the PR to update the documentation to state this.

[cvanem]

The transition components does not support the sx prop. The sx prop should be used in the inner component (the component they wrap and add the transition).

If this is not clear, maybe we can re-purpose the PR to update the documentation to state this.

@mnajdova This makes sense, however here is the source of confusion from my end:

1. The sx prop does appear to work on the Slide component, but only because the Transition component passes it to the children.

2. The Collapse component supports the sx prop and also uses the Transition component. It passes remaining props to it's children in a manner similar to the Slide component (via the Transition component).

Not sure what the best approach would be, but there does seem to be some inconsistency in the way the sx prop is handled with regards to the Collapse and Slide components. Is there a functional difference I am not seeing?

[mnajdova]

@cvanem I guess you meant the Slide, not Slider based on your comment :) I wouldn't add the sx prop in any of the transition components' props, as these components may be used with non Material UI components that do not support this prop. Regarding how props are propagated from the tranistion components I would assume that always the rest of the props that are not handled are going to be propagated to the children element.

So in conclusion, I would remove the sx prop the tranistion props, for example from the Collapse component, instead of adding it to other tranisiton components. However, this would be a breaking change, so I would propose we move this to our v6 milestone. I hope this clarifies the confusion.

[mnajdova]

I've added this in #30660, I propose we close this PR and open a new one for removing the sx prop once we start to work on the breaking changes for v6