New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alert] Add support for CSS vars #32624
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
209d0c9
[Alert] Support for CSS vars
haneenmahd f51a0c3
Add demo for Alert
haneenmahd a312004
Merge branch 'master' of https://github.com/mui/material-ui into css-…
siriwatknp 68e802d
add variables for Alert
siriwatknp 98ac689
Merge branch 'master' of https://github.com/mui/material-ui into css-…
siriwatknp 0929fad
add FilledColor variables
siriwatknp File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| import * as React from 'react'; | ||
| import { | ||
| Experimental_CssVarsProvider as CssVarsProvider, | ||
| useColorScheme, | ||
| } from '@mui/material/styles'; | ||
| import CssBaseline from '@mui/material/CssBaseline'; | ||
| import Box from '@mui/material/Box'; | ||
| import Button from '@mui/material/Button'; | ||
| import Container from '@mui/material/Container'; | ||
| import Moon from '@mui/icons-material/DarkMode'; | ||
| import Sun from '@mui/icons-material/LightMode'; | ||
| import { Alert } from '@mui/material'; | ||
|
|
||
| const ColorSchemePicker = () => { | ||
| const { mode, setMode } = useColorScheme(); | ||
| const [mounted, setMounted] = React.useState(false); | ||
| React.useEffect(() => { | ||
| setMounted(true); | ||
| }, []); | ||
| if (!mounted) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <Button | ||
| variant="outlined" | ||
| onClick={() => { | ||
| if (mode === 'light') { | ||
| setMode('dark'); | ||
| } else { | ||
| setMode('light'); | ||
| } | ||
| }} | ||
| > | ||
| {mode === 'light' ? <Moon /> : <Sun />} | ||
| </Button> | ||
| ); | ||
| }; | ||
|
|
||
| export default function CssVarsTemplate() { | ||
| return ( | ||
| <CssVarsProvider> | ||
| <CssBaseline /> | ||
| <Container sx={{ my: 5 }}> | ||
| <Box sx={{ pb: 2 }}> | ||
| <ColorSchemePicker /> | ||
| </Box> | ||
| <Box | ||
| sx={{ | ||
| display: 'grid', | ||
| gridTemplateColumns: 'repeat(auto-fill, minmax(256px, 1fr))', | ||
| gap: 2, | ||
| '& > div': { | ||
| placeSelf: 'center', | ||
| }, | ||
| }} | ||
| > | ||
| <Alert variant="filled" severity="error"> | ||
| This is an error alert — check it out! | ||
| </Alert> | ||
| <Alert variant="filled" severity="warning"> | ||
| This is a warning alert — check it out! | ||
| </Alert> | ||
| <Alert variant="filled" severity="info"> | ||
| This is an info alert — check it out! | ||
| </Alert> | ||
| <Alert variant="filled" severity="success"> | ||
| This is a success alert — check it out! | ||
| </Alert> | ||
| <Alert variant="standard" severity="error"> | ||
| This is an error alert — check it out! | ||
| </Alert> | ||
| <Alert variant="standard" severity="warning"> | ||
| This is a warning alert — check it out! | ||
| </Alert> | ||
| <Alert variant="standard" severity="info"> | ||
| This is an info alert — check it out! | ||
| </Alert> | ||
| <Alert variant="standard" severity="success"> | ||
| This is a success alert — check it out! | ||
| </Alert> | ||
| <Alert variant="outlined" severity="error"> | ||
| This is an error alert — check it out! | ||
| </Alert> | ||
| <Alert variant="outlined" severity="warning"> | ||
| This is a warning alert — check it out! | ||
| </Alert> | ||
| <Alert variant="outlined" severity="info"> | ||
| This is an info alert — check it out! | ||
| </Alert> | ||
| <Alert variant="outlined" severity="success"> | ||
| This is a success alert — check it out! | ||
| </Alert> | ||
| </Box> | ||
| </Container> | ||
| </CssVarsProvider> | ||
| ); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mnajdova I could not see other ways to reduce the number of tokens if we want to keep the same behavior. 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be tricky if people add custom colors here :\ Should we maybe create these based on the PaletteOptions type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should go that far for now. There is a trade-off because some people might not want the autogenerated variables (increase in bundle size) and we need to create more APIs to let them exclude things that they don't want.
At this point, I think we can leave the new custom palette effort to the developers and make sure that the docs are clear and comprehensive.