Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Joy] Make slider displays Joy classname #33051

Merged
merged 15 commits into from Jun 15, 2022
Merged

[Joy] Make slider displays Joy classname #33051

merged 15 commits into from Jun 15, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 7, 2022 •
edited

Preview: https://deploy-preview-33051--material-ui.netlify.app/joy-ui/react-slider/

The implementation in #32694 uses SliderUnstyled inside Joy which mean the class names will always be MuiSlider-....

This PR is required for #32972

Joy UI

This PR replaces the implementation using useSlider hook. It allows Joy to simplify the element of the ValueLabel:

// before
<span class="MuiSlider-valueLabel">
  <span class="MuiSlider-valueLabelOpen">
    <span class="MuiSlider-valueLabelCircle">
      <span class="MuiSlider-valueLabelLabel">
</span>

// after
<span class="JoySlider-valueLabel">
  label
</span>

MUI Base

  • Fixes types from useSlider to return appropriate types.

@siriwatknp siriwatknp added the package: joy-ui Specific to @mui/joy label Jun 7, 2022
@mui-bot
Copy link

mui-bot commented Jun 7, 2022 •
edited

Details of bundle changes

@mui/joy: parsed: -1.02% 😍, gzip: -1.20% 😍

Generated by 🚫 dangerJS against 2efa373

@siriwatknp siriwatknp requested a review from hbjORbj June 7, 2022 07:15
@siriwatknp siriwatknp mentioned this pull request Jun 10, 2022
Merged
1 task
@siriwatknp siriwatknp requested a review from mnajdova June 13, 2022 04:26
hbjORbj
hbjORbj approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking flawless to me.. 🥇

@siriwatknp siriwatknp merged commit 81608ba into mui:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj hbjORbj approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siriwatknp @mui-bot @hbjORbj