New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] Material UI CSS variables typing #33133
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rial-ui/css-vars
…rial-ui/css-vars
…rial-ui/css-vars
…rial-ui/css-vars
siriwatknp
added
typescript
package: material-ui
Specific to @mui/material
proof of concept
Studying and/or experimenting with a to be validated approach
labels
Jun 13, 2022
@material-ui/core: parsed: +1.65% , gzip: +0.95% |
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Jun 17, 2022
Closed in favor of #33211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: material-ui
Specific to @mui/material
PR: out-of-date
The pull request has merge conflicts and can't be merged
proof of concept
Studying and/or experimenting with a to be validated approach
typescript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://codesandbox.io/s/create-react-app-with-typescript-forked-1vjqxn?file=/src/App.tsx
Target experience
extendTheme
This is the new API for creating a theme for
CssVarsProvider
. The theme options type is extended from the existingTheme
types so it should work with the existing projects that have custom module augmentation.See the demo above.
Existing
Theme
typesThe CSS variables support is considered a new feature that developers can opt-in. The types augmentation should be minimal. It should work with existing APIs, eg.
styled
,sx
,useTheme
.With this goal, we can use the same approach to the lab by exporting
themeCssVarsAugmentation.d.ts
from Material UI package.All they need to do is:
It will extend the
theme
type that used instyled
,sx
,useTheme
to havetheme.vars
and the new tokens.See the demo above.
Existing
createTheme
The options type remains the same because this API is not intended to be used with CSS variables.
This is nice because the CSS variables types related won't be included if developers want to use
<ThemeProvider theme={createTheme()}>
.