New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Base] Add MUI base example #33154
[Base] Add MUI base example #33154
Conversation
I'm wondering what styling solution should we use. I'm not convinced about emotion. If we want to showcase a CSS-in-JS solution, we could advertise our System here. But also we could go as simple as possible and use plain CSS. Or maybe we need two examples ;) cc @mnajdova |
I oppose with plain CSS (if I have to create another file and come up with a class name, it is KO for me) but I totally agree with using |
@michaldudak Switched to We can change in the future if we don't want to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Add Base example to leverage the CodeSandbox package build in PRs. This PR started from my need to test the fix in #33145 via CodeSandbox (it is possible to manually install via command line but it is a slow process).
This is what the App.tsx looks like: