Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Base] Add MUI base example #33154

Merged
merged 3 commits into from Jul 8, 2022
Merged

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 15, 2022

Add Base example to leverage the CodeSandbox package build in PRs. This PR started from my need to test the fix in #33145 via CodeSandbox (it is possible to manually install via command line but it is a slow process).

This is what the App.tsx looks like:

Screen Shot 2565-06-15 at 10 18 47


@siriwatknp siriwatknp added the examples Relating to /examples label Jun 15, 2022
@mui-bot
Copy link

mui-bot commented Jun 15, 2022

No bundle size changes

Generated by 🚫 dangerJS against 6736a45

@michaldudak
Copy link
Member

I'm wondering what styling solution should we use. I'm not convinced about emotion. If we want to showcase a CSS-in-JS solution, we could advertise our System here. But also we could go as simple as possible and use plain CSS. Or maybe we need two examples ;)

cc @mnajdova

@siriwatknp
Copy link
Member Author

I'm wondering what styling solution should we use. I'm not convinced about emotion. If we want to showcase a CSS-in-JS solution, we could advertise our System here. But also we could go as simple as possible and use plain CSS. Or maybe we need two examples ;)

cc @mnajdova

I oppose with plain CSS (if I have to create another file and come up with a class name, it is KO for me) but I totally agree with using @mui/system instead of emotion.

@siriwatknp
Copy link
Member Author

siriwatknp commented Jul 7, 2022

@michaldudak Switched to @mui/system. Should we merge this to leverage the CodeSandbox CI?

We can change in the future if we don't want to use @mui/system. Examples are not tied to anything, so I think it is fine.

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@siriwatknp siriwatknp merged commit d527cac into mui:master Jul 8, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Relating to /examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants