[OutlinedInput] Fix ownerState
undefined in theme style overrides
#33241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31982
Root cause
No
ownerState
is provided toNotchedOutlineRoot
. This is strange at first because theNotchedOutlinedRoot
slot is notroot
but why the ownerState is logged.Each slot traverses the
styleOverrides
and passes props if the value is a function. In the end, the slot picks the resolved styles. That's why the callback is called multiple times even though it is declared on the root slot style overrides.We can't use @oliviertassinari 's fix at this point because it will be breaking changes. This is one example from InputBase:
Here is the InputBase root slot which looks for other various keys.
We could do the fix in v6 as breaking changes.