Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SnackbarContent] fix message text color with css var provider #33285

Merged
merged 3 commits into from Jul 4, 2022
Merged

[SnackbarContent] fix message text color with css var provider #33285

merged 3 commits into from Jul 4, 2022

Conversation

TimoWilhelm
Copy link
Contributor

#32049 (comment)

This PR fixes the SnackbarContent message text color to use the contrast text color instead of the primary text color.

@mui-bot
Copy link

mui-bot commented Jun 24, 2022 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against 41debd7

@TimoWilhelm
Copy link
Contributor Author

@siriwatknp could you please take a look at this? Thanks!

@siriwatknp
Copy link
Member

@siriwatknp could you please take a look at this? Thanks!

Sure, added to my list for next week!

siriwatknp
siriwatknp approved these changes Jul 3, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!🥰. Only one comment about the variable name, the rest looks good!

packages/mui-material/src/SnackbarContent/SnackbarContent.js Outdated Show resolved Hide resolved
packages/mui-material/src/styles/experimental_extendTheme.js Outdated Show resolved Hide resolved
packages/mui-material/src/styles/experimental_extendTheme.js Outdated Show resolved Hide resolved
@siriwatknp siriwatknp added the package: material-ui Specific to @mui/material label Jul 3, 2022
@siriwatknp
Copy link
Member

siriwatknp commented Jul 3, 2022 •
edited

❤️ Thanks for your first contribution, looking forward to the next one!

@siriwatknp siriwatknp merged commit 9ad8205 into mui:master Jul 4, 2022
@siriwatknp siriwatknp added the component: snackbar This is the name of the generic UI component, not the React module! label Jul 4, 2022
@maks-yaremishyn maks-yaremishyn mentioned this pull request Jul 13, 2022
Closed
65 tasks
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
@TimoWilhelm
[SnackbarContent] fix message text color with css var provider (mui#3…
48ee9ff 
…3285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: snackbar This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TimoWilhelm @mui-bot @siriwatknp