[base] Removes invisible tabbable elements from TrapFocus component #33677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And as it turns out, there does exist a reopen button that I wasn't seeing. So now I'm closing this... this is a little embarrassing at this point 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
Described in issue #33380
Solution
Setting
tabIndex={open ? 0 : -1}onsentinelStartandsentinelEndelements so that they're only tabbable when theTrapFocusopenprop istrue. Thus removing the awkward experience where there are invisible tabbable elements.Whoops
This is a replacement for this PR which was based off a fork of
master. When I tried to sync my fork from upstream the PR autoclosed 🤦