[docs] Fix incorrect Cases icon
#33688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before
After
|
PunitSoniME
changed the title
PunitSoniME
changed the title
robonetphy
approved these changes
Jul 29, 2022
PunitSoniME
changed the title
ZeeshanTamboli
changed the title
Cases icon
ZeeshanTamboli
added
bug 🐛
robonetphy
approved these changes
Aug 8, 2022
siriwatknp
requested changes
Aug 8, 2022
There was a problem hiding this comment.
I think you have to update packages/mui-icons-material/lib/esm/Cases.js as well. I am not if we download from material design icons again, would it revert this PR changes? cc @michaldudak
PunitSoniME
commented
Aug 8, 2022
robonetphy
approved these changes
Aug 19, 2022
|
We don't accept PRs to fix individual icons (see https://github.com/mui/material-ui/blob/master/packages/mui-icons-material/README.md#contributing), as we periodically sync the whole set with Google. I'm going to update the whole set, as it hasn't been done in a while. Here's the PR: #33988. Unfortunately, the updated set does not include the fixed Cases icon. There is an issue in the Material Icons repo that reports this problem. Please upvote it if you need this icon fixed. |
michaldudak
added
the
external dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33673
Preview: https://deploy-preview-33688--material-ui.netlify.app/material-ui/material-icons/?query=cases
Or
After - Codesandbox