-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stepper] Fix classes for icon container #33734
Conversation
Can you add unit tests to this file? https://github.com/mui/material-ui/blob/master/packages/mui-material/src/Stepper/Stepper.test.tsx e.g., const items = container.querySelectorAll(`.${stepConnectorClasses.iconContainer}`);
expect(items[0]).to.have.class(stepClasses.completed);
expect(items[0]).to.have.class(stepClasses.active);
... |
Sure. I'll start with unit tests. |
Hi @hbjORbj, I have added unit tests. PTAL, Thanks! |
Hi team @hbjORbj, @siriwatknp, @michaldudak, @mnajdova, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ Thanks for your first contribution! Look forward to seeing more.
I have tested this fix locally and also tested using a preview package on CodeSandbox.
May close #33410