Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix reported SEO issues #33818

Merged
merged 5 commits into from Aug 11, 2022
Merged

[docs] Fix reported SEO issues #33818

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f103af2
[docs] Fix reported SEO issues
oliviertassinari Aug 6, 2022
2c086c3
fix redirection
oliviertassinari Aug 6, 2022
4130304
improve heading structure
oliviertassinari Aug 6, 2022
e13f23a
fix duplication in the title
oliviertassinari Aug 6, 2022
9f15398
fix CI
oliviertassinari Aug 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.old.md
View file
Open in desktop
Expand Up @@ -11418,7 +11418,7 @@ _Apr 6, 2017_

We are continuing investing in the documentation and the test suite.

Visual regression tests are now sent to [argos-ci](https://www.argos-ci.com/mui/material-ui).
Visual regression tests are now sent to [argos-ci](https://app.argos-ci.com/mui/material-ui/builds).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a 404 now

Thanks @agamrafaeli for increasing the test coverage of 1% since the last release (95.23%).
Thanks @mbrookes for fixing the inconsistency of the API and improving the API.

Expand Down
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Expand Up @@ -120,7 +120,7 @@ Visit our [`styled-engine` guide](https://mui.com/material-ui/guides/styled-engi

<p align="center">
<a href="https://octopus.com/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="128" width="128" src="https://i.ibb.co/w0HF0Nz/Logo-Blue-140px-rgb.png" alt="octopus" title="Repeatable, reliable deployments" loading="lazy" /></a>
<a href="https://www.doit-intl.com/flexsave/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="128" width="128" src="https://avatars3.githubusercontent.com/u/8424863?s=256" alt="doit-intl" title="Management Platform for Google Cloud and AWS" loading="lazy" /></a>
<a href="https://www.doit-intl.com/flexsave/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="128" width="128" src="https://avatars.githubusercontent.com/u/8424863?s=256" alt="doit-intl" title="Management Platform for Google Cloud and AWS" loading="lazy" /></a>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hit the main subdomain, let the infrastructure load balance behind the scene

<a href="https://www.zesty.io/integrations/nextjs-cms/?utm_source=mui&utm_medium=referral&utm_campaign=sponsor" rel="noopener sponsored" target="_blank"><img height="90" width="90" src="https://brand.zesty.io/zesty-io-logo.svg" alt="zesty.io" title="The only Next.js CMS you need" loading="lazy" /></a>
</p>

Expand All @@ -131,14 +131,14 @@ Diamond Sponsors are those who have pledged \$1,500/month or more to MUI.
via [OpenCollective](https://opencollective.com/mui) or via [Patreon](https://www.patreon.com/oliviertassinari)

<p align="center">
<a href="https://tidelift.com/subscription/pkg/npm-material-ui?utm_source=npm-material-ui&utm_medium=referral&utm_campaign=homepage" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://github.com/tidelift.png?size=192" alt="tidelift.com" title="Enterprise-ready open-source software" loading="lazy" /></a>
<a href="https://bit.dev/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank" style="margin-rig ht: 16px;"><img height="96" width="96" src="https://github.com/teambit.png?size=192" alt="bit.dev" title="The fastest way to share code" loading="lazy" /></a>
<a href="https://www.text-em-all.com/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img src="https://images.opencollective.com/callemall/09710fe/logo/192.png" alt="text-em-all.com" title="Mass Text Messaging & Automated Calling" height="96" width="96" loading="lazy"></a>
<a href="https://tidelift.com/subscription/pkg/npm-material-ui?utm_source=npm-material-ui&utm_medium=referral&utm_campaign=homepage" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://avatars.githubusercontent.com/u/30204434?s=192" alt="tidelift.com" title="Enterprise-ready open-source software" loading="lazy" /></a>
<a href="https://bit.dev/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank" style="margin-rig ht: 16px;"><img height="96" width="96" src="https://avatars.githubusercontent.com/u/24789812?s=192" alt="bit.dev" title="The fastest way to share code" loading="lazy" /></a>
<a href="https://www.text-em-all.com/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img src="https://avatars.githubusercontent.com/u/1262264?s=192" alt="text-em-all.com" title="Mass Text Messaging & Automated Calling" height="96" width="96" loading="lazy"></a>
<a href="https://online-aussie-casino.com/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://images.opencollective.com/aussiecasinohex/923df37/logo/192.png" alt="online-aussie-casino.com" title="Aussie Gambling Guide" loading="lazy" /></a>
<a href="https://sumatosoft.com/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://images.opencollective.com/sumatosoft_company/0b78570/avatar/192.png" alt="sumatosoft.com" title="We help companies to digitalize their businesses" loading="lazy" /></a>
<a href="https://megafamous.com/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://p18.zdusercontent.com/attachment/9422375/Rullx0rw9lUGKuyKOy4VQ9Zxq?size=192" alt="megafamous.com" title="The best place to buy Instagram followers & likes." loading="lazy" /></a>
<a href="https://megafamous.com/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://mui.com/static/sponsors/megafamous.png" alt="megafamous.com" title="The best place to buy Instagram followers & likes." loading="lazy" /></a>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't work

Screenshot 2022-08-06 at 13 48 31

https://github.com/mui/material-ui#gold

<a href="https://www.dialmycalls.com/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://images.opencollective.com/dialmycalls/f5ae9ab/avatar/192.png" alt="dialmycalls.com" title="Send text messages, calls & emails to thousands with ease." loading="lazy" /></a>
<a href="https://goread.io/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://goread.io/assets/uploads/usereb4ac3033e8ab3591e0fcefa8c26ce3fd36d5a0f/bd81e54effbcc265ad169015455a0c1e.png" alt="goread.io" title="Instagram followers, likes, power likes, views, comments, saves in minutes." loading="lazy" /></a>
<a href="https://goread.io/?utm_source=MUI&utm_medium=referral&utm_content=readme" rel="noopener sponsored" target="_blank"><img height="96" width="96" src="https://images.opencollective.com/goread_io/eb6337d/logo/192.png" alt="goread.io" title="Instagram followers, likes, power likes, views, comments, saves in minutes." loading="lazy" /></a>
</p>

Gold Sponsors are those who have pledged \$500/month or more to MUI.
Expand Down
16 changes: 14 additions & 2 deletions docs/data/joy/components/tabs/TabsPageExample.js
View file
Open in desktop
Expand Up @@ -102,12 +102,24 @@ export default function TabsBasic() {
})}
>
<TabPanel value={0}>
<Typography level="h1" fontSize="xl2" mb={2} textColor="text.secondary">
<Typography
level="h1"
component="div"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix https://app.ahrefs.com/site-audit/3524616/24/data-explorer?columns=pageRating%2Curl%2Ctraffic%2ChttpCode%2Cdepth%2Ch1%2Ch1Length%2CnrH1%2Ccompliant&filterCollapsed=true&filterId=377676a0df737bc09d40ffe8c8f9e699&issueId=c64d52ef-d0f4-11e7-8ed1-001e67ed4656

Screenshot 2022-08-06 at 13 45 36

cc @siriwatknp

fontSize="xl2"
mb={2}
textColor="text.secondary"
>
Deals
</Typography>
</TabPanel>
<TabPanel value={1}>
<Typography level="h1" fontSize="xl2" mb={2} textColor="text.secondary">
<Typography
level="h1"
component="div"
fontSize="xl2"
mb={2}
textColor="text.secondary"
>
Library
</Typography>
</TabPanel>
Expand Down
16 changes: 14 additions & 2 deletions docs/data/joy/components/tabs/TabsPageExample.tsx
View file
Open in desktop
Expand Up @@ -102,12 +102,24 @@ export default function TabsBasic() {
})}
>
<TabPanel value={0}>
<Typography level="h1" fontSize="xl2" mb={2} textColor="text.secondary">
<Typography
level="h1"
component="div"
fontSize="xl2"
mb={2}
textColor="text.secondary"
>
Deals
</Typography>
</TabPanel>
<TabPanel value={1}>
<Typography level="h1" fontSize="xl2" mb={2} textColor="text.secondary">
<Typography
level="h1"
component="div"
fontSize="xl2"
mb={2}
textColor="text.secondary"
>
Library
</Typography>
</TabPanel>
Expand Down
2 changes: 1 addition & 1 deletion docs/data/joy/components/typography/typography.md
View file
Open in desktop
Expand Up @@ -86,7 +86,7 @@ The `Typography` component has access to the typographic level scale defined in
Use the `level` prop to control the scale value.

:::info
**Keep in mind:** each level renders a specific HTML tag (e.g. "h1" renders as an `<h2>` element, "body1" renders as a `<p>`, etc.)
**Keep in mind:** each level renders a specific HTML tag (e.g. "h1" renders as an `<h1>` element, "body1" renders as a `<p>`, etc.)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it was a typo, cc @siriwatknp

:::

{{"demo": "TypographyScales.js"}}
Expand Down
6 changes: 5 additions & 1 deletion docs/data/joy/getting-started/overview/overview.md
View file
Open in desktop
@@ -1,4 +1,8 @@
# Joy UI－Overview
---
title: Overview
---

# Joy UI - Overview
Comment on lines +1 to +5
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix https://app.ahrefs.com/site-audit/3524616/24/data-explorer?columns=pageRating%2Curl%2Ctraffic%2Ctitle%2Cserp_title%2Cis_page_title_used_in_serp%2Ctop_keyword%2Ctop_keyword_position&filterCollapsed=true&filterId=207cf10d892e807e0aaeafdf8fc70712&issueId=d69246c2-225a-11ec-8456-06d2f2f613d8

Screenshot 2022-08-06 at 13 46 39

cc @samuelsycamore


<p class="description">Joy UI is a library of beautifully designed React UI components.</p>

Expand Down
16 changes: 8 additions & 8 deletions docs/data/material/components/typography/Types.js
View file
Open in desktop
Expand Up @@ -5,29 +5,29 @@ import Typography from '@mui/material/Typography';
export default function Types() {
return (
<Box sx={{ width: '100%', maxWidth: 500 }}>
<Typography variant="h1" component="div" gutterBottom>
<Typography variant="h1" gutterBottom>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replicate the tradeoff taken in https://mui.com/joy-ui/react-typography/#levels there are no reasons to have a different tradeoff AFAIK, I'm using Joy UI's tradeoff for Material UI, sounds like a better DX. cc @siriwatknp

h1. Heading
</Typography>
<Typography variant="h2" gutterBottom component="div">
<Typography variant="h2" gutterBottom>
h2. Heading
</Typography>
<Typography variant="h3" gutterBottom component="div">
<Typography variant="h3" gutterBottom>
h3. Heading
</Typography>
<Typography variant="h4" gutterBottom component="div">
<Typography variant="h4" gutterBottom>
h4. Heading
</Typography>
<Typography variant="h5" gutterBottom component="div">
<Typography variant="h5" gutterBottom>
h5. Heading
</Typography>
<Typography variant="h6" gutterBottom component="div">
<Typography variant="h6" gutterBottom>
h6. Heading
</Typography>
<Typography variant="subtitle1" gutterBottom component="div">
<Typography variant="subtitle1" gutterBottom>
subtitle1. Lorem ipsum dolor sit amet, consectetur adipisicing elit. Quos
blanditiis tenetur
</Typography>
<Typography variant="subtitle2" gutterBottom component="div">
<Typography variant="subtitle2" gutterBottom>
subtitle2. Lorem ipsum dolor sit amet, consectetur adipisicing elit. Quos
blanditiis tenetur
</Typography>
Expand Down
16 changes: 8 additions & 8 deletions docs/data/material/components/typography/Types.tsx
View file
Open in desktop
Expand Up @@ -5,29 +5,29 @@ import Typography from '@mui/material/Typography';
export default function Types() {
return (
<Box sx={{ width: '100%', maxWidth: 500 }}>
<Typography variant="h1" component="div" gutterBottom>
<Typography variant="h1" gutterBottom>
h1. Heading
</Typography>
<Typography variant="h2" gutterBottom component="div">
<Typography variant="h2" gutterBottom>
h2. Heading
</Typography>
<Typography variant="h3" gutterBottom component="div">
<Typography variant="h3" gutterBottom>
h3. Heading
</Typography>
<Typography variant="h4" gutterBottom component="div">
<Typography variant="h4" gutterBottom>
h4. Heading
</Typography>
<Typography variant="h5" gutterBottom component="div">
<Typography variant="h5" gutterBottom>
h5. Heading
</Typography>
<Typography variant="h6" gutterBottom component="div">
<Typography variant="h6" gutterBottom>
h6. Heading
</Typography>
<Typography variant="subtitle1" gutterBottom component="div">
<Typography variant="subtitle1" gutterBottom>
subtitle1. Lorem ipsum dolor sit amet, consectetur adipisicing elit. Quos
blanditiis tenetur
</Typography>
<Typography variant="subtitle2" gutterBottom component="div">
<Typography variant="subtitle2" gutterBottom>
subtitle2. Lorem ipsum dolor sit amet, consectetur adipisicing elit. Quos
blanditiis tenetur
</Typography>
Expand Down