Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add the download tracker package #33899

Merged
merged 4 commits into from Aug 15, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -7,7 +7,7 @@
"deduplicate": "node scripts/deduplicate.js",
"benchmark:browser": "yarn workspace benchmark browser",
"build:codesandbox": "lerna run --parallel --scope \"@mui/*\" build",
"release:version": "lerna version --no-changelog --no-push --no-git-tag-version",
"release:version": "lerna version --no-changelog --no-push --no-git-tag-version --force-publish=@mui/internal-usage-tracker",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"release:build": "lerna run --parallel --scope \"@mui/*\" build",
"release:changelog": "node scripts/releaseChangelog",
"release:publish": "lerna publish from-package --dist-tag latest --contents build",
Expand Down
5 changes: 5 additions & 0 deletions packages/mui-internal-usage-tracker/README.md
@@ -0,0 +1,5 @@
# @mui/internal-usage-tracker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe? So it feels less frightening from a privacy perspective. No, it doesn't include telemetry.

Suggested change
# @mui/internal-usage-tracker
# @mui/internal-download-tracker

Same for the title of this PR for the changelog


Also from a namespace perspective, since @mui is shared between all products, maybe a prefix with core would help.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the download tracker since it sounds less scary at a glance

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mui/core-internal-download-tracker, then?


This package does not contain any code.
It is used solely to track number of downloads of @mui/material and @mui/joy (the only packages that depend on it) and help us determine the number of users of @mui/base.
Counting downloads is done by npm (as for every other package).
1 change: 1 addition & 0 deletions packages/mui-internal-usage-tracker/index.js
@@ -0,0 +1 @@
export default null;
25 changes: 25 additions & 0 deletions packages/mui-internal-usage-tracker/package.json
@@ -0,0 +1,25 @@
{
"name": "@mui/internal-usage-tracker",
"version": "5.10.0",
"private": false,
"author": "MUI Team",
"description": "Internal package to track number of downloads of our design system libraries",
"main": "./index.js",
"repository": {
"type": "git",
"url": "https://github.com/mui/material-ui.git",
"directory": "packages/mui-internal-usage-tracker"
},
"license": "MIT",
"bugs": {
"url": "https://github.com/mui/material-ui/issues"
},
"homepage": "https://mui.com/",
"funding": {
"type": "opencollective",
"url": "https://opencollective.com/mui"
},
"scripts": {
"release": "npm publish ."
}
}
1 change: 1 addition & 0 deletions packages/mui-joy/package.json
Expand Up @@ -58,6 +58,7 @@
"dependencies": {
"@babel/runtime": "^7.17.2",
"@mui/base": "5.0.0-alpha.92",
"@mui/internal-usage-tracker": "5.10.0",
"@mui/system": "^5.10.0",
"@mui/types": "^7.1.5",
"@mui/utils": "^5.9.3",
Expand Down
1 change: 1 addition & 0 deletions packages/mui-material/package.json
Expand Up @@ -62,6 +62,7 @@
"dependencies": {
"@babel/runtime": "^7.17.2",
"@mui/base": "5.0.0-alpha.92",
"@mui/internal-usage-tracker": "5.10.0",
"@mui/system": "^5.10.0",
"@mui/types": "^7.1.5",
"@mui/utils": "^5.9.3",
Expand Down