Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Fix keepMounted Popper prop not working #33957

Merged
merged 7 commits into from Aug 19, 2022
Merged

[Autocomplete] Fix keepMounted Popper prop not working #33957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9c9253a
add test
ZeeshanTamboli Aug 16, 2022
4360d6e
add logic
ZeeshanTamboli Aug 16, 2022
555fcfc
update test description
ZeeshanTamboli Aug 16, 2022
a788759
Merge branch 'master' into issue/33881-autocomplete-keepMounted-poppe…
ZeeshanTamboli Aug 17, 2022
204001d
prettier
ZeeshanTamboli Aug 17, 2022
a5a34e9
remove popupOpen check in width style
ZeeshanTamboli Aug 19, 2022
ffd8860
Merge branch 'master' into issue/33881-autocomplete-keepMounted-poppe…
ZeeshanTamboli Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/mui-material/src/Autocomplete/Autocomplete.js
View file
Open in desktop
Expand Up @@ -592,7 +592,7 @@ const Autocomplete = React.forwardRef(function Autocomplete(inProps, ref) {
},
})}
</AutocompleteRoot>
{popupOpen && anchorEl ? (
{anchorEl ? (
<AutocompletePopper
as={PopperComponent}
disablePortal={disablePortal}
Expand All @@ -602,7 +602,7 @@ const Autocomplete = React.forwardRef(function Autocomplete(inProps, ref) {
ownerState={ownerState}
role="presentation"
anchorEl={anchorEl}
open
open={popupOpen}
{...componentsProps.popper}
className={clsx(classes.popper, componentsProps.popper?.className)}
>
Expand Down
16 changes: 16 additions & 0 deletions packages/mui-material/src/Autocomplete/Autocomplete.test.js
View file
Open in desktop
Expand Up @@ -2525,6 +2525,22 @@ describe('<Autocomplete />', () => {
expect(popupIndicator).to.have.class(iconButtonClasses.sizeLarge);
expect(popupIndicator).to.have.class('my-class');
});

it('should keep AutocompletePopper mounted if keepMounted is true in popper props', () => {
// Autocomplete is not opened
render(
<Autocomplete
options={['one', 'two']}
renderInput={(params) => <TextField {...params} />}
componentsProps={{
popper: { 'data-testid': 'popperRoot', keepMounted: true },
}}
/>,
);

const popperRoot = screen.getByTestId('popperRoot');
expect(popperRoot.style.display).to.equal('none');
});
});

describe('prop: readOnly', () => {
Expand Down