Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix ListItem button deprecated use #33970

Merged
merged 3 commits into from Dec 21, 2022
Merged

[docs] Fix ListItem button deprecated use #33970

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbc23e1
fix simple dialog deprecated attribute
MickaelAustoni Aug 17, 2022
e563617
Improve the DOM structure
mnajdova Dec 21, 2022
b718207
Merge branch 'master' into docs-simple-dialog
mnajdova Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/data/material/components/dialogs/SimpleDialog.js
View file
Open in desktop
Expand Up @@ -3,8 +3,8 @@ import PropTypes from 'prop-types';
import Button from '@mui/material/Button';
import Avatar from '@mui/material/Avatar';
import List from '@mui/material/List';
import ListItem from '@mui/material/ListItem';
import ListItemAvatar from '@mui/material/ListItemAvatar';
import ListItemButton from '@mui/material/ListItemButton';
import ListItemText from '@mui/material/ListItemText';
import DialogTitle from '@mui/material/DialogTitle';
import Dialog from '@mui/material/Dialog';
Expand All @@ -31,24 +31,24 @@ function SimpleDialog(props) {
<DialogTitle>Set backup account</DialogTitle>
<List sx={{ pt: 0 }}>
{emails.map((email) => (
<ListItem button onClick={() => handleListItemClick(email)} key={email}>
<ListItemButton onClick={() => handleListItemClick(email)} key={email}>
mnajdova marked this conversation as resolved.
Show resolved Hide resolved
<ListItemAvatar>
<Avatar sx={{ bgcolor: blue[100], color: blue[600] }}>
<PersonIcon />
</Avatar>
</ListItemAvatar>
<ListItemText primary={email} />
</ListItem>
</ListItemButton>
))}

<ListItem autoFocus button onClick={() => handleListItemClick('addAccount')}>
<ListItemButton autoFocus onClick={() => handleListItemClick('addAccount')}>
<ListItemAvatar>
<Avatar>
<AddIcon />
</Avatar>
</ListItemAvatar>
<ListItemText primary="Add account" />
</ListItem>
</ListItemButton>
</List>
</Dialog>
);
Expand Down
10 changes: 5 additions & 5 deletions docs/data/material/components/dialogs/SimpleDialog.tsx
View file
Open in desktop
Expand Up @@ -2,8 +2,8 @@ import * as React from 'react';
import Button from '@mui/material/Button';
import Avatar from '@mui/material/Avatar';
import List from '@mui/material/List';
import ListItem from '@mui/material/ListItem';
import ListItemAvatar from '@mui/material/ListItemAvatar';
import ListItemButton from '@mui/material/ListItemButton';
import ListItemText from '@mui/material/ListItemText';
import DialogTitle from '@mui/material/DialogTitle';
import Dialog from '@mui/material/Dialog';
Expand Down Expand Up @@ -36,23 +36,23 @@ function SimpleDialog(props: SimpleDialogProps) {
<DialogTitle>Set backup account</DialogTitle>
<List sx={{ pt: 0 }}>
{emails.map((email) => (
<ListItem button onClick={() => handleListItemClick(email)} key={email}>
<ListItemButton onClick={() => handleListItemClick(email)} key={email}>
<ListItemAvatar>
<Avatar sx={{ bgcolor: blue[100], color: blue[600] }}>
<PersonIcon />
</Avatar>
</ListItemAvatar>
<ListItemText primary={email} />
</ListItem>
</ListItemButton>
))}
<ListItem autoFocus button onClick={() => handleListItemClick('addAccount')}>
<ListItemButton autoFocus onClick={() => handleListItemClick('addAccount')}>
<ListItemAvatar>
<Avatar>
<AddIcon />
</Avatar>
</ListItemAvatar>
<ListItemText primary="Add account" />
</ListItem>
</ListItemButton>
</List>
</Dialog>
);
Expand Down